fix warnings

Author: arturcic

.editorconfig

@@ -64,6 +64,7 @@ dotnet_style_prefer_simplified_interpolation = true:suggestion
 dotnet_diagnostic.IDE0067.severity = none
 dotnet_diagnostic.IDE0068.severity = none
 dotnet_diagnostic.IDE0069.severity = none
+dotnet_diagnostic.CA1016.severity = none
 
 #### C# Coding Conventions ####
 

build/common/Utilities/Constants.cs

@@ -18,7 +18,7 @@ public class Constants
 
     public static readonly Architecture[] ArchToBuild = { Architecture.Amd64, Architecture.Arm64 };
     public static readonly string[] VersionsToBuild = { Version60, Version70 };
-    public static readonly string[] DistrosToSkipForArtifacts = { Alpine315, Alpine316, Alpine317, Centos7 };
+    public static readonly string[] DistrosToSkipForArtifacts = { Alpine315, Alpine316, Alpine317, Centos7, Ubuntu2204 };
     public static readonly string[] DistrosToSkipForDocker = { Centos7 };
 
     public const string DockerBaseImageName = "gittools/build-images";

src/GitTools.Testing/Fixtures/SequenceDiagram.cs

@@ -105,7 +105,7 @@ public void BranchToFromTag(string branchName, string fromTag, string onBranch,
     /// </summary>
     public void Merge(string from, string to) => this.diagramBuilder.AppendLineFormat("{0} -> {1}: merge", GetParticipant(from), GetParticipant(to));
 
-    private string GetParticipant(string branch) => this.participants.ContainsKey(branch) ? this.participants[branch] : branch;
+    private string GetParticipant(string branch) => participants.TryGetValue(branch, out var value) ? value : branch;
 
     /// <summary>
     /// Ends the sequence diagram

src/GitTools.Testing/Internal/DirectoryHelper.cs

@@ -23,7 +23,7 @@ public static void CopyFilesRecursively(DirectoryInfo source, DirectoryInfo targ
         }
     }
 
-    private static string Rename(string name) => ToRename.ContainsKey(name) ? ToRename[name] : name;
+    private static string Rename(string name) => ToRename.TryGetValue(name, out var value) ? value : name;
 
     public static void DeleteSubDirectories(string parentPath)
     {

src/GitVersion.App.Tests/Helpers/GitVersionHelper.cs

@@ -52,14 +52,7 @@ private static ExecutionResults ExecuteIn(ArgumentBuilder arguments,
 
         foreach (var (key, value) in environments)
         {
-            if (environmentalVariables.ContainsKey(key))
-            {
-                environmentalVariables[key] = value;
-            }
-            else
-            {
-                environmentalVariables.Add(key, value);
-            }
+            environmentalVariables[key] = value;
         }
 
         var exitCode = -1;

src/GitVersion.Core.Tests/Extensions/GitToolsTestingExtensions.cs

@@ -44,7 +44,7 @@ public static IBranch CreateMockBranch(string name, params ICommit[] commits)
         return branch;
     }
 
-    public static IBranch? FindBranch(this IGitRepository repository, string branchName) => repository.Branches.FirstOrDefault(x => x.Name.WithoutRemote == branchName);
+    public static IBranch FindBranch(this IGitRepository repository, string branchName) => repository.Branches.First(x => x.Name.WithoutRemote == branchName) ?? throw new GitVersionException($"Branch {branchName} not found");
 
     public static void DumpGraph(this IGitRepository repository, Action<string>? writer = null, int? maxCommits = null) => GitExtensions.DumpGraph(repository.Path, writer, maxCommits);
 

src/GitVersion.Core.Tests/Helpers/DirectoryHelper.cs

@@ -24,7 +24,7 @@ public static void CopyFilesRecursively(DirectoryInfo source, DirectoryInfo targ
         }
     }
 
-    private static string Rename(string name) => ToRename.ContainsKey(name) ? ToRename[name] : name;
+    private static string Rename(string name) => ToRename.TryGetValue(name, out var value) ? value : name;
 
     public static void DeleteSubDirectories(string parentPath)
     {

src/GitVersion.Core.Tests/Helpers/GitVersionContextBuilder.cs

@@ -19,9 +19,9 @@ public GitVersionContextBuilder WithRepository(IGitRepository gitRepository)
         return this;
     }
 
-    public GitVersionContextBuilder WithConfig(GitVersionConfiguration configuration)
+    public GitVersionContextBuilder WithConfig(GitVersionConfiguration configurationInfo)
     {
-        this.configuration = configuration;
+        this.configuration = configurationInfo;
         return this;
     }
 
@@ -57,14 +57,14 @@ public void Build()
     {
         var repo = this.repository ?? CreateRepository();
 
-        var configuration = new ConfigurationBuilder()
+        var configurationInfo = new ConfigurationBuilder()
             .Add(this.configuration ?? new GitVersionConfiguration())
             .Build();
 
         var options = Options.Create(new GitVersionOptions
         {
             WorkingDirectory = new EmptyRepositoryFixture().RepositoryPath,
-            ConfigInfo = { OverrideConfig = configuration }
+            ConfigInfo = { OverrideConfig = configurationInfo }
         });
 
         this.ServicesProvider = ConfigureServices(services =>

src/GitVersion.Core.Tests/Helpers/TestConfigurationBuilderBase.cs

@@ -294,7 +294,7 @@ private static void ValidateConfiguration(GitVersionConfiguration configuration)
                 throw new ConfigurationException($"Branch configuration '{name}' is missing required configuration 'regex'{helpUrl}");
             }
 
-            var sourceBranches = branchConfiguration?.SourceBranches;
+            var sourceBranches = branchConfiguration.SourceBranches;
             if (sourceBranches == null)
             {
                 throw new ConfigurationException($"Branch configuration '{name}' is missing required configuration 'source-branches'{helpUrl}");

src/GitVersion.Core.Tests/Helpers/TestFileSystem.cs

@@ -85,14 +85,7 @@ public Stream OpenRead(string path)
     public void CreateDirectory(string path)
     {
         var fullPath = Path.GetFullPath(path);
-        if (this.fileSystem.ContainsKey(fullPath))
-        {
-            this.fileSystem[fullPath] = Array.Empty<byte>();
-        }
-        else
-        {
-            this.fileSystem.Add(fullPath, Array.Empty<byte>());
-        }
+        this.fileSystem[fullPath] = Array.Empty<byte>();
     }
 
     public bool DirectoryExists(string path)