refactor(GitVersion.Core): assign 'default' constants to their properties

Author: BinToss

src/GitVersion.Core/Configuration/GitVersionConfiguration.cs

@@ -7,6 +7,15 @@
 
 namespace GitVersion.Configuration;
 
+/// <summary>
+/// GitVersion's Configuration definition.
+/// </summary>
+/// <remarks>
+///     Default values are defined as constants in <see
+///     cref="ConfigurationConstants" /> and then assigned to their respective
+///     fields and properties. This is so each compile-time constant value can
+///     be assigned to a property and the property's attribute(s).
+/// </remarks>
 internal sealed record GitVersionConfiguration : BranchConfiguration, IGitVersionConfiguration
 {
     [JsonPropertyName("workflow")]
@@ -16,22 +25,22 @@ internal sealed record GitVersionConfiguration : BranchConfiguration, IGitVersio
     [JsonPropertyName("assembly-versioning-scheme")]
     [JsonPropertyDescription($"The scheme to use when setting AssemblyVersion attribute. Can be 'MajorMinorPatchTag', 'MajorMinorPatch', 'MajorMinor', 'Major', 'None'. Defaults to '{NameOfDefaultAssemblyVersioningScheme}'.")]
     [JsonPropertyDefault(DefaultAssemblyVersioningScheme)]
-    public AssemblyVersioningScheme? AssemblyVersioningScheme { get; internal set; }
+    public AssemblyVersioningScheme? AssemblyVersioningScheme { get; internal set; } = DefaultAssemblyVersioningScheme;
 
     [JsonPropertyName("assembly-file-versioning-scheme")]
     [JsonPropertyDescription($"The scheme to use when setting AssemblyFileVersion attribute. Can be 'MajorMinorPatchTag', 'MajorMinorPatch', 'MajorMinor', 'Major', 'None'. Defaults to {NameOfDefaultAssemblyFileVersioningScheme}")]
     [JsonPropertyDefault(DefaultAssemblyFileVersioningScheme)]
-    public AssemblyFileVersioningScheme? AssemblyFileVersioningScheme { get; internal set; }
+    public AssemblyFileVersioningScheme? AssemblyFileVersioningScheme { get; internal set; } = DefaultAssemblyFileVersioningScheme;
 
     [JsonPropertyName("assembly-informational-format")]
     [JsonPropertyDescription($"Specifies the format of AssemblyInformationalVersion. The defaults to '{DefaultAssemblyInformationalFormat}'.")]
     [JsonPropertyDefault(DefaultAssemblyInformationalFormat)]
-    public string? AssemblyInformationalFormat { get; internal set; }
+    public string? AssemblyInformationalFormat { get; internal set; } = DefaultAssemblyInformationalFormat;
 
     [JsonPropertyName("assembly-versioning-format")]
     [JsonPropertyDescription("Specifies the format of AssemblyVersion and overwrites the value of assembly-versioning-scheme.")]
     [JsonPropertyDefault(DefaultAssemblyVersioningFormat)]
-    public string? AssemblyVersioningFormat { get; internal set; }
+    public string? AssemblyVersioningFormat { get; internal set; } = DefaultAssemblyVersioningFormat;
 
     [JsonPropertyName("assembly-file-versioning-format")]
     [JsonPropertyDescription("Specifies the format of AssemblyFileVersion and overwrites the value of assembly-file-versioning-scheme.")]
@@ -55,7 +64,7 @@ internal sealed record GitVersionConfiguration : BranchConfiguration, IGitVersio
     private string GetVersionInBranchPattern()
     {
         var versionInBranchPattern = VersionInBranchPattern;
-        if (versionInBranchPattern.IsNullOrEmpty()) versionInBranchPattern = ConfigurationConstants.DefaultVersionInBranchPattern;
+        if (versionInBranchPattern.IsNullOrEmpty()) versionInBranchPattern = DefaultVersionInBranchPattern;
         return $"^{versionInBranchPattern.TrimStart('^')}";
     }
 
@@ -74,34 +83,34 @@ public string? NextVersion
     [JsonPropertyName("major-version-bump-message")]
     [JsonPropertyDescription($"The regular expression to match commit messages with to perform a major version increment. Default set to '{IncrementStrategyFinder.DefaultMajorPattern}'")]
     [JsonPropertyDefault(IncrementStrategyFinder.DefaultMajorPattern, true)]
-    public string? MajorVersionBumpMessage { get; internal set; }
+    public string? MajorVersionBumpMessage { get; internal set; } = IncrementStrategyFinder.DefaultMajorPattern;
 
     [JsonPropertyName("minor-version-bump-message")]
     [JsonPropertyDescription($"The regular expression to match commit messages with to perform a minor version increment. Default set to '{IncrementStrategyFinder.DefaultMinorPattern}'")]
     [JsonPropertyDefault(IncrementStrategyFinder.DefaultMinorPattern, true)]
-    public string? MinorVersionBumpMessage { get; internal set; }
+    public string? MinorVersionBumpMessage { get; internal set; } = IncrementStrategyFinder.DefaultMinorPattern;
 
     [JsonPropertyName("patch-version-bump-message")]
     [JsonPropertyDescription($"The regular expression to match commit messages with to perform a patch version increment. Default set to '{IncrementStrategyFinder.DefaultPatchPattern}'")]
     [JsonPropertyDefault(IncrementStrategyFinder.DefaultPatchPattern, true)]
-    public string? PatchVersionBumpMessage { get; internal set; }
+    public string? PatchVersionBumpMessage { get; internal set; } = IncrementStrategyFinder.DefaultPatchPattern;
 
     [JsonPropertyName("no-bump-message")]
     [JsonPropertyDescription($"Used to tell GitVersion not to increment when in Mainline development mode. Default set to '{IncrementStrategyFinder.DefaultNoBumpPattern}'")]
     [JsonPropertyDefault(IncrementStrategyFinder.DefaultNoBumpPattern, true)]
-    public string? NoBumpMessage { get; internal set; }
+    public string? NoBumpMessage { get; internal set; } = IncrementStrategyFinder.DefaultNoBumpPattern;
 
     [JsonPropertyName("tag-pre-release-weight")]
     [JsonPropertyDescription($"The pre-release weight in case of tagged commits. Defaults to {StringDefaultTagReleaseWeight}.")]
-    public int? TagPreReleaseWeight { get; internal set; }
+    public int? TagPreReleaseWeight { get; internal set; } = DefaultTagReleaseWeight;
 
     [JsonPropertyName("commit-date-format")]
     [JsonPropertyDescription($"The format to use when calculating the commit date. Defaults to '{DefaultCommitDateFormat}'. See [Standard Date and Time Format Strings](https://learn.microsoft.com/en-us/dotnet/standard/base-types/standard-date-and-time-format-strings) and [Custom Date and Time Format Strings](https://learn.microsoft.com/en-us/dotnet/standard/base-types/standard-date-and-time-format-strings).")]
     [JsonPropertyDefault(DefaultCommitDateFormat, true)]
 #if NET7_0_OR_GREATER
     [System.Diagnostics.CodeAnalysis.StringSyntax("DateTimeFormat")] // See https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.stringsyntaxattribute, https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.stringsyntaxattribute.datetimeformat?view=net-7.0#system-diagnostics-codeanalysis-stringsyntaxattribute-datetimeformat
 #endif
-    public string? CommitDateFormat { get; internal set; }
+    public string? CommitDateFormat { get; internal set; } = DefaultCommitDateFormat;
 
     [JsonPropertyName("merge-message-formats")]
     [JsonPropertyDescription("Custom merge message formats to enable identification of merge messages that do not follow the built-in conventions.")]
@@ -113,12 +122,12 @@ public string? NextVersion
     [JsonPropertyName("update-build-number")]
     [JsonPropertyDescription($"Whether to update the build number in the project file. Defaults to {StringDefaultUpdateBuildNumber}.")]
     [JsonPropertyDefault(DefaultUpdateBuildNumber)]
-    public bool UpdateBuildNumber { get; internal set; }
+    public bool UpdateBuildNumber { get; internal set; } = DefaultUpdateBuildNumber;
 
     [JsonPropertyName("semantic-version-format")]
     [JsonPropertyDescription($"Specifies the semantic version format that is used when parsing the string. Can be 'Strict' or 'Loose'. Defaults to '{StringDefaultSemanticVersionFormat}'.")]
     [JsonPropertyDefault(DefaultSemanticVersionFormat)]
-    public SemanticVersionFormat SemanticVersionFormat { get; internal set; }
+    public SemanticVersionFormat SemanticVersionFormat { get; internal set; } = DefaultSemanticVersionFormat;
 
     [JsonIgnore]
     IReadOnlyDictionary<string, IBranchConfiguration> IGitVersionConfiguration.Branches