refactor(GitVersion.Configuration, GitVersion.Core): do not enclose JsonPropertyDefaultAttribute values in quotes

Author: BinToss

src/GitVersion.Configuration/GitVersionConfiguration.cs

@@ -47,12 +47,12 @@ internal sealed record GitVersionConfiguration : BranchConfiguration, IGitVersio
 
     [JsonPropertyName("tag-prefix")]
     [JsonPropertyDescription($"A regular expression which is used to trim Git tags before processing. Defaults to '{DefaultTagPrefix}'")]
-    [JsonPropertyDefault(DefaultTagPrefix, true)]
+    [JsonPropertyDefault(DefaultTagPrefix)]
     public string? TagPrefix { get; internal set; }
 
     [JsonPropertyName("version-in-branch-pattern")]
     [JsonPropertyDescription($"A regular expression which is used to determine the version number in the branch name or commit message (e.g., v1.0.0-LTS). Defaults to '{DefaultVersionInBranchPattern}'.")]
-    [JsonPropertyDefault(DefaultVersionInBranchPattern, true)]
+    [JsonPropertyDefault(DefaultVersionInBranchPattern)]
     public string? VersionInBranchPattern { get; internal set; }
 
     [JsonIgnore]
@@ -80,22 +80,22 @@ public string? NextVersion
 
     [JsonPropertyName("major-version-bump-message")]
     [JsonPropertyDescription($"The regular expression to match commit messages with to perform a major version increment. Defaults to '{IncrementStrategyFinder.DefaultMajorPattern}'")]
-    [JsonPropertyDefault(IncrementStrategyFinder.DefaultMajorPattern, true)]
+    [JsonPropertyDefault(IncrementStrategyFinder.DefaultMajorPattern)]
     public string? MajorVersionBumpMessage { get; internal set; } = IncrementStrategyFinder.DefaultMajorPattern;
 
     [JsonPropertyName("minor-version-bump-message")]
     [JsonPropertyDescription($"The regular expression to match commit messages with to perform a minor version increment. Defaults to '{IncrementStrategyFinder.DefaultMinorPattern}'")]
-    [JsonPropertyDefault(IncrementStrategyFinder.DefaultMinorPattern, true)]
+    [JsonPropertyDefault(IncrementStrategyFinder.DefaultMinorPattern)]
     public string? MinorVersionBumpMessage { get; internal set; } = IncrementStrategyFinder.DefaultMinorPattern;
 
     [JsonPropertyName("patch-version-bump-message")]
     [JsonPropertyDescription($"The regular expression to match commit messages with to perform a patch version increment. Defaults to '{IncrementStrategyFinder.DefaultPatchPattern}'")]
-    [JsonPropertyDefault(IncrementStrategyFinder.DefaultPatchPattern, true)]
+    [JsonPropertyDefault(IncrementStrategyFinder.DefaultPatchPattern)]
     public string? PatchVersionBumpMessage { get; internal set; } = IncrementStrategyFinder.DefaultPatchPattern;
 
     [JsonPropertyName("no-bump-message")]
     [JsonPropertyDescription($"Used to tell GitVersion not to increment when in Mainline development mode. Defaults to '{IncrementStrategyFinder.DefaultNoBumpPattern}'")]
-    [JsonPropertyDefault(IncrementStrategyFinder.DefaultNoBumpPattern, true)]
+    [JsonPropertyDefault(IncrementStrategyFinder.DefaultNoBumpPattern)]
     public string? NoBumpMessage { get; internal set; } = IncrementStrategyFinder.DefaultNoBumpPattern;
 
     [JsonPropertyName("tag-pre-release-weight")]
@@ -104,7 +104,7 @@ public string? NextVersion
 
     [JsonPropertyName("commit-date-format")]
     [JsonPropertyDescription($"The format to use when calculating the commit date. Defaults to '{DefaultCommitDateFormat}'. See [Standard Date and Time Format Strings](https://learn.microsoft.com/en-us/dotnet/standard/base-types/standard-date-and-time-format-strings) and [Custom Date and Time Format Strings](https://learn.microsoft.com/en-us/dotnet/standard/base-types/standard-date-and-time-format-strings).")]
-    [JsonPropertyDefault(DefaultCommitDateFormat, true)]
+    [JsonPropertyDefault(DefaultCommitDateFormat)]
 #if NET7_0_OR_GREATER
     [System.Diagnostics.CodeAnalysis.StringSyntax("DateTimeFormat")] // See https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.stringsyntaxattribute, https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.stringsyntaxattribute.datetimeformat?view=net-7.0#system-diagnostics-codeanalysis-stringsyntaxattribute-datetimeformat
 #endif

src/GitVersion.Core/Core/Attributes/JsonPropertyDefaultAttribute.cs

@@ -12,22 +12,17 @@ public sealed class JsonPropertyDefaultAttribute : JsonAttribute
     public JsonPropertyDefaultAttribute(string? value) => Value = value ?? "null";
 
     /// <inheritdoc cref="JsonPropertyDefaultAttribute(string)"/>
-    /// <param name="value"><inheritdoc cref="JsonPropertyDefaultAttribute(string)" path="param[@name='value']"/></param>
-    /// <param name="enclose">If <see langword="true"/>, the default value is enclosed with single-quotes, strongly implying the value is a <c>string-type</c>.</param>
-    public JsonPropertyDefaultAttribute(string value, bool enclose) : this(enclose ? $"'{value}'" : $"{value}") { }
-
-    /// <inheritdoc cref="JsonPropertyDefaultAttribute(string,bool)"/>
     public JsonPropertyDefaultAttribute(bool value) : this(value ? "true" : "false") { }
 
-    /// <inheritdoc cref="JsonPropertyDefaultAttribute(string,bool)"/>
-    /// <remarks>The Enum value is converted to string-preferring the symbol name over the numeral if possible--and the resulting string is enclosed with single-quotes.</remarks>
-    public JsonPropertyDefaultAttribute(SemanticVersionFormat value) : this(value.ToString(), true) { }
+    /// <inheritdoc cref="JsonPropertyDefaultAttribute(string)"/>
+    /// <remarks>The Enum value is converted to string, preferring the symbol name over the numeral if possible.</remarks>
+    public JsonPropertyDefaultAttribute(SemanticVersionFormat value) : this(value.ToString()) { }
     /// <inheritdoc cref="JsonPropertyDefaultAttribute(SemanticVersionFormat)"/>
-    public JsonPropertyDefaultAttribute(AssemblyVersioningScheme value) : this(value.ToString(), true) { }
+    public JsonPropertyDefaultAttribute(AssemblyVersioningScheme value) : this(value.ToString()) { }
     /// <inheritdoc cref="JsonPropertyDefaultAttribute(SemanticVersionFormat)"/>
-    public JsonPropertyDefaultAttribute(AssemblyFileVersioningScheme value) : this(value.ToString(), true) { }
+    public JsonPropertyDefaultAttribute(AssemblyFileVersioningScheme value) : this(value.ToString()) { }
 
-    /// <inheritdoc cref="JsonPropertyDefaultAttribute(string, bool)"/>
+    /// <inheritdoc cref="JsonPropertyDefaultAttribute(string)"/>
     /// <remarks>Depending on the Type of the boxed value, the resulting string will be automatically enclosed with single-quotes. If the boxed value is NOT a string and is converted to a string from a numeric , object, array, boolean, or null-only type, then it will NOT be enclosed with single-quotes.</remarks>
     public JsonPropertyDefaultAttribute(object boxedValue)
     {

src/GitVersion.Core/PublicAPI.Unshipped.txt

@@ -47,7 +47,6 @@ GitVersion.Attributes.JsonPropertyDefaultAttribute.JsonPropertyDefaultAttribute(
 GitVersion.Attributes.JsonPropertyDefaultAttribute.JsonPropertyDefaultAttribute(GitVersion.Extensions.AssemblyVersioningScheme value) -> void
 GitVersion.Attributes.JsonPropertyDefaultAttribute.JsonPropertyDefaultAttribute(GitVersion.SemanticVersionFormat value) -> void
 GitVersion.Attributes.JsonPropertyDefaultAttribute.JsonPropertyDefaultAttribute(object! boxedValue) -> void
-GitVersion.Attributes.JsonPropertyDefaultAttribute.JsonPropertyDefaultAttribute(string! value, bool enclose) -> void
 GitVersion.Attributes.JsonPropertyDescriptionAttribute
 GitVersion.Attributes.JsonPropertyDescriptionAttribute.Description.get -> string!
 GitVersion.Attributes.JsonPropertyDescriptionAttribute.JsonPropertyDescriptionAttribute(string! description) -> void