This repository was archived by the owner on Jan 6, 2021. It is now read-only.
Migrates library to .NETStandard 1.3 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
conniey
commented
Jul 2, 2017
conniey
commented
- Required for testing in GitVersion.Core for .NET Standard (Port to NETStandard GitTools.Core#40)
- TODO: Replace Libgit2Sharp.Portable with LibGit2Sharp that supports .NET Standard when the package is created from: Target .NET Standard 1.3 libgit2/libgit2sharp#1318
This was referenced Jul 9, 2017
|
Is anyone able to merge this so that it can unblock upstream PR's? |
|
@dazinator: Done! |
|
Amazeballs! |
|
@asbjornu - has this been released to nuget? The appveyor build has 1.1.1-beta0001 as an artifact, yet that nuget package dates back to 22nd april on the nuget page: https://www.nuget.org/packages/GitTools.Testing/1.1.1-beta0001 |
|
@dazinator: I assume we need something like GitTools/GitTools.Core@e76c34f for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.