This repository was archived by the owner on Jun 27, 2019. It is now read-only.
WIP: Never move head when normalising #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should move dynamic repos to GitTools.Core so we can just initialize a repo in all the tooling. |
|
That is my plan, I updated all the APIs in this PR to get it ready to switch. The code was put into core but GitVersion never switched over. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug where HEAD would move when normalising =/ Not good, this introduces race conditions in the builds. We should backport this to 3.x in gitversion.
Also we should remove the Dynamic repo code from gitversion or GitTools.Core. I am happy to leave it in here, but want to fix it up a bit so made a start. Have to go out now but putting this up for initial visibility.
// @asbjornu @gep13 @GeertvanHorrik