minified constructor parameter names after production-build

[civilizeddev]

Description

Some packaging-for-production-distribution libraries, such as react-scripts (used by create-react-app), pkg (Node Binary Packager), minify JS file on its variable names. With it constructor parameter names are not preserved. It makes @JsonProprty() on constructor parameters not working.

Any idea on this?

[GillianPerard]

Hi!

For the moment I haven’t.

Could you try to pass the real json name to JsonProperty ?

constructor(@JsonProperty(‘name’) public name: string) {}

[GillianPerard]

Hi, thank you for the PR, I'll test it as soon as possible.

Could you just provide me how did you test with a minifier please ?

[civilizeddev]

Steps to reproduce

I tested it on my react application, but it is also used in server side. For now I'll describe it for client side only.

1. Create a project using create-react-app
2. Define a data model class (e.g. Student) with properties on constructor parameters with typescript-json-serializer decorators.
3. It is enough just with index.tsx and Student.ts.
4. Write a pair of serialize/deserialize code on index.tsx.
5. Try yarn build to make a production-build, which will minify the code.
6. Run it on local web server.
7. Open Chrome DevTools and check the console. (Finished)

[civilizeddev]

I think it is good to prepare the minified code before the test phase starts.
Could you do that on gulpfile.js?

[GillianPerard]

Thanks for the test flow.

Honestly I don't know, let me check.

[civilizeddev]

I'm looking forward to hearing from you.

[GillianPerard]

Hi,

If I try to use decorators in CRA project, when I try to get design:type it always returns undefined and break my lib.

You don't have any errors on your side ? If no, how did you do that ? ^^'

PS: It seems to be a Babel limitation

[civilizeddev]

No, it works very well on my side.

I made a pull request for poc of this.

[GillianPerard]

Hi, I made some modifications and it works for CRA but it still not work for angular.

I'm investigating.

EDIT: I've checked and it seems that AOT removes custom decorators from constructor and there is no solution for the moment, then Angular users may only use JsonProperty on property directly and not on constructor params (https://github.com/angular/angular-cli/issues/9306).
Let me know if #38 is good for you, then I'll publish it.

[civilizeddev]

It's good for me. Thanks.