Remove deprecated SendRtp and SendRtcp functions

and delete remaining usages.

Bug: webrtc:15410
Change-Id: I912bedca80a5a446a3f770211d164a5eb0af02bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320520
Reviewed-by: Danil Chapovalov <[email protected]>
Commit-Queue: Harald Alvestrand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#40766}

Author: Harald Alvestrand

api/call/transport.h

@@ -45,29 +45,9 @@ struct PacketOptions {
 
 class Transport {
  public:
-  // New style functions. Default implementations are to accomodate
-  // subclasses that haven't been converted to new style yet.
-  // TODO(bugs.webrtc.org/14870): Deprecate and remove old functions.
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
   virtual bool SendRtp(rtc::ArrayView<const uint8_t> packet,
-                       const PacketOptions& options) {
-    return SendRtp(packet.data(), packet.size(), options);
-  }
-  virtual bool SendRtcp(rtc::ArrayView<const uint8_t> packet) {
-    return SendRtcp(packet.data(), packet.size());
-  }
-#pragma clang diagnostic pop
-  // Old style functions.
-  [[deprecated("Use ArrayView version")]] virtual bool
-  SendRtp(const uint8_t* packet, size_t length, const PacketOptions& options) {
-    return SendRtp(rtc::MakeArrayView(packet, length), options);
-  }
-  [[deprecated("Use ArrayView version")]] virtual bool SendRtcp(
-      const uint8_t* packet,
-      size_t length) {
-    return SendRtcp(rtc::MakeArrayView(packet, length));
-  }
+                       const PacketOptions& options) = 0;
+  virtual bool SendRtcp(rtc::ArrayView<const uint8_t> packet) = 0;
 
  protected:
   virtual ~Transport() {}

examples/androidvoip/jni/android_voip_client.cc

@@ -427,10 +427,9 @@ void AndroidVoipClient::SendRtpPacket(const std::vector<uint8_t>& packet_copy) {
   }
 }
 
-bool AndroidVoipClient::SendRtp(const uint8_t* packet,
-                                size_t length,
+bool AndroidVoipClient::SendRtp(rtc::ArrayView<const uint8_t> packet,
                                 const webrtc::PacketOptions& options) {
-  std::vector<uint8_t> packet_copy(packet, packet + length);
+  std::vector<uint8_t> packet_copy(packet.begin(), packet.end());
   voip_thread_->PostTask([this, packet_copy = std::move(packet_copy)] {
     SendRtpPacket(packet_copy);
   });
@@ -447,8 +446,8 @@ void AndroidVoipClient::SendRtcpPacket(
   }
 }
 
-bool AndroidVoipClient::SendRtcp(const uint8_t* packet, size_t length) {
-  std::vector<uint8_t> packet_copy(packet, packet + length);
+bool AndroidVoipClient::SendRtcp(rtc::ArrayView<const uint8_t> packet) {
+  std::vector<uint8_t> packet_copy(packet.begin(), packet.end());
   voip_thread_->PostTask([this, packet_copy = std::move(packet_copy)] {
     SendRtcpPacket(packet_copy);
   });

examples/androidvoip/jni/android_voip_client.h

@@ -118,10 +118,9 @@ class AndroidVoipClient : public webrtc::Transport,
   void Delete(JNIEnv* env);
 
   // Implementation for Transport.
-  bool SendRtp(const uint8_t* packet,
-               size_t length,
+  bool SendRtp(rtc::ArrayView<const uint8_t> packet,
                const webrtc::PacketOptions& options) override;
-  bool SendRtcp(const uint8_t* packet, size_t length) override;
+  bool SendRtcp(rtc::ArrayView<const uint8_t> packet) override;
 
   // Slots for sockets to connect to.
   void OnSignalReadRTPPacket(rtc::AsyncPacketSocket* socket,