Skip to content

Commit 2d93725

Browse files
authored
Merge 70cb9e8 into 24e36d2
2 parents 24e36d2 + 70cb9e8 commit 2d93725

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

packages/stream_feed/lib/src/core/error/stream_feeds_error.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@ class StreamFeedsNetworkError extends StreamFeedsError {
4242
factory StreamFeedsNetworkError.fromDioError(DioError error) {
4343
final response = error.response;
4444
ErrorResponse? errorResponse;
45-
final data = json.decode(response?.data);
46-
if (data != null) {
47-
errorResponse = ErrorResponse.fromJson(data);
45+
if (response?.data != null) {
46+
errorResponse = ErrorResponse.fromJson(json.decode(response!.data));
4847
}
4948
return StreamFeedsNetworkError.raw(
5049
code: errorResponse?.code ?? -1,

packages/stream_feed/test/stream_feeds_error_test.dart

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,20 @@ void main() {
1717
expect(error.message, message);
1818
});
1919

20+
test('time out', () {
21+
const message = 'Connecting timed out [0ms]';
22+
final options = RequestOptions(path: 'test-path');
23+
24+
final dioError = DioError(
25+
requestOptions: options,
26+
error: 'Connecting timed out [${options.connectTimeout}ms]',
27+
type: DioErrorType.connectTimeout,
28+
);
29+
final error = StreamFeedsNetworkError.fromDioError(dioError);
30+
expect(error, isNotNull);
31+
expect(error.message, message);
32+
});
33+
2034
test('.fromDioError', () {
2135
const code = 333;
2236
const statusCode = 666;

0 commit comments

Comments
 (0)