Test improvements #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good. "All test passed successfully." I like it. |
Closed
|
Does anyone know if this has already been incorporated in another PR? If this gets updated to resolve the conflicts I will do my best to merge it right away. |
|
@karimbahgat Feel free to take ownership of this issue. I keep not being able to find the time to update it. |
karimbahgat
added a commit
that referenced
this pull request
Apr 29, 2017
Default test verbosity to False to make it easier to spot the test failures. Partially fixes #54.
|
Great. Seems like most of these have been addressed in some way by previous contributions. Others were incorporated in #95. Didn't address the test file cleanup, as I am not sure what problems or test errors might come of it. If anyone else is willing to go down this route that's fine too, but for now I'm okay leaving this as is. Therefore considering this mostly fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates rebased #43.
Closes #43.
Travis CI build log.