Skip to content

Mark tests requiring network. #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

sebastic
Copy link
Contributor

@sebastic sebastic commented Feb 2, 2022

The Debian package build for pyshp failed because there is no network in the build environment.

The tests that download data need to be skipped, for this the network marker was added to test_reader_url().

Allows skipping tests in environments without network.
@karimbahgat karimbahgat merged commit d3d83a9 into GeospatialPython:master Feb 2, 2022
@sebastic sebastic deleted the no-network branch February 3, 2022 04:40
@musicinmybrain
Copy link
Contributor

Thanks for this! As the maintainer of the corresponding Fedora package, it helps me out too.

(Unfortunately, I have to resort to some ugly sed hackery to accomplish the same thing in the doctests, and I’m not sure how best to do that more cleanly in a way that I offer upstream.)

@sebastic
Copy link
Contributor Author

sebastic commented Feb 3, 2022

(Unfortunately, I have to resort to some ugly sed hackery to accomplish the same thing in the doctests, and I’m not sure how best to do that more cleanly in a way that I offer upstream.)

I chose to stop running those, now that a better test framework is also used. I considered adding a patch to strip out those examples, but considered it not worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants