-
Notifications
You must be signed in to change notification settings - Fork 228
Add shading to grdview gallery example #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me, but I remember @weiji14 may want to add some comments in the example?
Co-authored-by: Wei Ji <[email protected]>
@weiji14 so once these statuses pass, I may merge? |
Yes! Just click on the 'Squash and merge' button. You might want to format the commit message a bit, just summarize what was done and leave out things like 'fix typo'. |
Description of proposed changes
Add shading to the new
grdview()
example. This requires the bugfix of GMT 6.1.0 and will not work in 6.0.0, so we should probably wait to merge this until v0.2.0 is released — this is more of a bookmark. But it looks awesome:This is an improvement on #502. @weiji14 please let me know what inline comments / other improvements we should have as well.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.