Finalize fixes on WIndows test suite for v0.1.1 #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exact error message was "ValueError: path is on mount 'C:', start on mount 'D:'."
|
Last 2 tests to fix! Investigating now, might be related to how ================================== FAILURES ===================================
__________________ [doctest] pygmt.clib.conversion._as_array __________________
221
222 Examples
223 --------
224
225 >>> import pandas as pd
226 >>> x_series = pd.Series(data=[1, 2, 3, 4])
227 >>> x_array = _as_array(x_series)
228 >>> type(x_array)
229 <class 'numpy.ndarray'>
230 >>> x_array
Expected:
array([1, 2, 3, 4])
Got:
array([1, 2, 3, 4], dtype=int64)
C:\Miniconda\envs\testing\Lib\site-packages\pygmt\clib\conversion.py:230: DocTestFailure
___________ [doctest] pygmt.clib.conversion.kwargs_to_ctypes_array ____________
263 Returns
264 -------
265 ctypes_value : ctypes array or None
266
267 Examples
268 --------
269
270 >>> import ctypes as ct
271 >>> value = kwargs_to_ctypes_array('bla', {'bla': [10, 10]}, ct.c_int*2)
272 >>> type(value)
Expected:
<class 'pygmt.clib.conversion.c_int_Array_2'>
Got:
<class 'pygmt.clib.conversion.c_long_Array_2'>
C:\Miniconda\envs\testing\Lib\site-packages\pygmt\clib\conversion.py:272: DocTestFailure |
|
Perhaps change the tests a little bit. For example, changing to |
The .values method isn't recommended anymore for pandas 1.0, see https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.values.html#pandas.Series.values. Using to_numpy() instead.
weiji14
commented
May 21, 2020
Because running np.asarray on a pandas.Series returns a numpy.ndarray anyway.
According to https://docs.python.org/3/library/ctypes.html#ctypes-tutorial, `c_int` is just an alias for `c_long`.
weiji14
commented
May 21, 2020
Comment on lines
-271
to
+231
| >>> value = kwargs_to_ctypes_array('bla', {'bla': [10, 10]}, ct.c_int*2) | ||
| >>> value = kwargs_to_ctypes_array('bla', {'bla': [10, 10]}, ct.c_long*2) | ||
| >>> type(value) | ||
| <class 'pygmt.clib.conversion.c_int_Array_2'> | ||
| <class 'pygmt.clib.conversion.c_long_Array_2'> |
There was a problem hiding this comment.
c_int is just an alias for c_long according to https://docs.python.org/3/library/ctypes.html#ctypes-tutorial. Changing it to c_long should make this test pass in a cross-platform way.
seisman
approved these changes
May 21, 2020
|
Awesome, all green and good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Towards a fully working Windows test suite! Several of our unit tests (~8) have been failing since #434, and we've addressed them in several PRs already. This one will hopefully squash the last of them.
Merge after these are completed (in order):
logoimage discrepancy with conda ghostscript (Let PyGMT work with the conda GMT package on Windows #434)gmt.dllwithoutGMT_LIBRARY_PATHenvironment variable (Improve how PyGMT finds the GMT library #440)Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.