Update GMT constant GMT_STR16 to GMT_VF_LEN for GMT API change in 6.1.0 #397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
PyGMT fails with the latest GMT master branch with the following error message:
If you have the GMT master branch installed, you can reproduce the issue by
The error is caused by the recent change of the length of virtual file names
from
GMT_STR16
toGMT_VF_LEN
in the core GMT(see GenericMappingTools/gmt#2861).
Changing
GMT_STR16
toGMT_VF_LEN
is the easiest fix.To keep compatibility with both GMT 6.0.0 and the upcomming 6.1.0,
this PR checks GMT version and use
GMT_STR16
for 6.0.0, otherwiseuse
GMT_VF_LEN
.Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.