-
Notifications
You must be signed in to change notification settings - Fork 228
GMTDataArrayAccessor: Enable grid operations on the current xarray.DataArray object directly #3854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seisman
wants to merge
14
commits into
main
Choose a base branch
from
accessor/gridop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−3
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9c74046
Extend GMTDataAccessor to support grid operations
seisman fe7612c
Merge branch 'main' into accessor/gridop
seisman 8b95908
Merge branch 'main' into accessor/gridop
seisman 4853128
Add more grid operations to GMTDataArrayAccessor
seisman 8d039aa
Merge branch 'main' into accessor/gridop
seisman 505c9d0
Add docstrings for the new methods
seisman f49c3d0
Fix docstrings
seisman 58ee6a1
Fix docstrings
seisman c43e6c6
Merge branch 'main' into accessor/gridop
seisman d2527ae
Merge branch 'main' into accessor/gridop
seisman 49490d5
Update docstrings
seisman db42b7a
Add equalize_hist method
seisman de29785
Merge branch 'main' into accessor/gridop
seisman a341d39
Merge branch 'main' into accessor/gridop
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shorter way to declare new methods is to put this in the
__init__
method:This would preserve the full docs too, e.g. output from
help(grid.gmt.dimfilter)
There might be a nicer way to wrap things (maybe using https://docs.python.org/3/library/functools.html#functools.update_wrapper?), but haven't played around with it too much.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried your solution above and found two issues:
self.dimfilter
is an attribute of the accessor, so it's not shown on the documentation (https://pygmt-dev--3854.org.readthedocs.build/en/3854/api/generated/pygmt.GMTDataArrayAccessor.html)help
docs still showgrid
as its first parameter, which may be more confusing?