Skip to content

Quickfix min/max elevation for new SRTM15+V2 earth relief grids #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2019

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Oct 20, 2019

Upstream GMT has updated its earth relief grids (see GenericMappingTools/gmt#1846) to use the new Global Bathymetry and Topography at 15 Arc Sec (SRTM15+V2) data by @btozer and others!

References:

  • Tozer, B., Sandwell, D. T., Smith, W. H. F., Olson, C., Beale, J. R., & Wessel, P. (2019). Global Bathymetry and Topography at 15 Arc Sec: SRTM15+. Earth and Space Science. https://doi.org/10.1029/2019EA000658

Description of proposed changes

This pull request fixes the test failures by changing the minimum/maximum elevation values to that of the new earth relief grids.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Upstream GMT has updated its earth relief grids to use the new [Tozer et al. 2019](https://doi.org/10.1029/2019EA000658) Global Bathymetry and Topography at 15 Arc Sec (SRTM15+V2) data, see GenericMappingTools/gmt#1846. This resulted in a couple of test failures because of changed minimum/maximum elevation values, which this commit addresses.
@weiji14 weiji14 requested a review from a team October 20, 2019 08:47
@weiji14 weiji14 self-assigned this Oct 20, 2019
@weiji14
Copy link
Member Author

weiji14 commented Oct 20, 2019

Hmm, I would have thought there would be more tests (e.g. from grdimage) failing. Is the @pytest.mark.mpl_image_compare decorator not doing its job properly?!!

@seisman
Copy link
Member

seisman commented Oct 20, 2019

The grdimage tests use the lowest resolution (60m) earth relief data. I think we can't see any difference between the old and new dataset for such low resolution.

@weiji14
Copy link
Member Author

weiji14 commented Oct 20, 2019

Yes, but surely there would be some?? I'll merge this in first and investigate later.

@weiji14 weiji14 merged commit 72c0f21 into GenericMappingTools:master Oct 20, 2019
@weiji14 weiji14 deleted the earthrelief/srtm15+v2 branch October 20, 2019 21:28
weiji14 referenced this pull request in weiji14/pygmt Nov 1, 2019
Due to new SRTM15+V2 grids, see also #350.
weiji14 referenced this pull request in weiji14/pygmt Nov 7, 2019
Refresh baseline plots to use SRTM15+V2 grids as per #350, and also some fixed some filenames after being caught by pytest's matplotlib image comparison (thanks to #352!).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants