Skip to content

Use consistently "netCDF" #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 7, 2023
Merged

Use consistently "netCDF" #2620

merged 14 commits into from
Aug 7, 2023

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Aug 3, 2023

Description of proposed changes

This PR aims to use consistently netCDF (not NetCDF or netcdf).
For context please see: #2617 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Aug 3, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.10.0 milestone Aug 3, 2023
@yvonnefroehlich yvonnefroehlich changed the title WIP: Fix 'NetCDF' to 'netCDF' WIP: Replace "NetCDF" by "netCDF" Aug 3, 2023
@yvonnefroehlich yvonnefroehlich self-assigned this Aug 4, 2023
@yvonnefroehlich yvonnefroehlich changed the title WIP: Replace "NetCDF" by "netCDF" WIP: Use consistently "netCDF" Aug 5, 2023
@yvonnefroehlich yvonnefroehlich changed the title WIP: Use consistently "netCDF" Use consistently "netCDF" Aug 5, 2023
@yvonnefroehlich yvonnefroehlich added the needs review This PR has higher priority and needs review. label Aug 5, 2023
@seisman
Copy link
Member

seisman commented Aug 6, 2023

Please also fix line 70 in doc/contributing.md.

@yvonnefroehlich
Copy link
Member Author

Please also fix line 70 in doc/contributing.md.

Done in commit 71c2a47.

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Aug 6, 2023
@seisman seisman merged commit 016a0f4 into main Aug 7, 2023
@seisman seisman deleted the fix-NetCDF-to-netCDF branch August 7, 2023 00:00
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 7, 2023
weiji14 added a commit that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants