-
Notifications
You must be signed in to change notification settings - Fork 228
Fix setting "sharex", "sharey", and "frame" of Figure.subplot in combination with Figure.basemap #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix setting "sharex", "sharey", and "frame" of Figure.subplot in combination with Figure.basemap #2417
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9528c3d
Remove setting 'frame' if not given
yvonnefroehlich 389173d
Remove un-needed import of 'args_in_kwargs'
yvonnefroehlich 614dca7
[format-command] fixes
actions-bot 47cb47f
Merge branch 'main' into fix-subplot-frame
yvonnefroehlich 3aa1374
Revert commit c274463
yvonnefroehlich f431db6
Merge branch 'main' into fix-subplot-frame
yvonnefroehlich c0a3523
Improve error message (code review)
yvonnefroehlich 6442186
Merge branch 'main' into fix-subplot-frame
yvonnefroehlich 8e9d4e5
Remove check
yvonnefroehlich 3c90376
Merge branch 'main' into fix-subplot-frame
yvonnefroehlich 0ad5c76
Remove un-used import
yvonnefroehlich 75de44d
Fix imports - all in one line
yvonnefroehlich faf9aca
More precise formulation (code review)
yvonnefroehlich 6065479
Add comma
yvonnefroehlich 37710f1
Remove test 'test_basemap_required_args'
yvonnefroehlich 7285fa5
Remove un-used import
yvonnefroehlich 0716819
Add test
yvonnefroehlich 913b43d
[format-command] fixes
actions-bot ad44310
Simplify unit test (code review)
yvonnefroehlich 46ef398
Remove un-used variables
yvonnefroehlich 6829489
Merge branch 'main' into fix-subplot-frame
yvonnefroehlich db256f0
Merge branch 'main' into fix-subplot-frame
yvonnefroehlich 162a354
Merge branch 'main' into fix-subplot-frame
yvonnefroehlich 6fba473
Merge branch 'main' into fix-subplot-frame
yvonnefroehlich e1ffbdb
Add test_basemap_subplot.png into DVC
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
outs: | ||
- md5: 1b4ae53658eec125ebf8ab4eac78d729 | ||
size: 8733 | ||
path: test_basemap_subplot.png |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.