-
Notifications
You must be signed in to change notification settings - Fork 228
Add area_thresh to COMMON_OPTIONS #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It sounds reasonable to me. Two thoughts:
|
Or we can define two separate dicts (e.g., COMMON_OPTIONS and NONCOMMON_OPTIONS) and another dict that is the combination of both. |
Will do that!
I would go with this option @seisman. Maybe a good first issue to add some comments explaining that the dictionary contains both, common and non-common options? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Co-authored-by: Meghan Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just missing one close bracket, otherwise looks good. Thanks!
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😀
Co-authored-by: Wei Ji <[email protected]>
I think this PR is ready to merge. Feel free to merge it when you have time @michaelgrund |
* update pygmt/helpers/decorators.py * update docstring in coast Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Wei Ji <[email protected]>
Description of proposed changes
While working on #1423 I recognized that the -A alias already implemented in
coast
as area_thresh is also used in several other modules likegrdlandmask
,grdmath
andgmtselect
. This PR adds area_thresh to the common options list.Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version