Skip to content

Fix pygmt/helpers/testing.py doctest for GMT 6.2.0rc1 #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 27, 2021

Description of proposed changes

Update doctests in pygmt/helpers/testing.py's check_figures_equal function failing because of new GMT 6.2.0 themes default. Specifically caused by the change in MAP_FRAME_AXES from WESNZ to auto (WrStZ for Cartesian figures).

Address #1217

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 27, 2021
@weiji14 weiji14 self-assigned this Apr 27, 2021
@seisman seisman added this to the 0.4.0 milestone Apr 27, 2021
@seisman seisman merged commit 3c9f463 into master Apr 27, 2021
@seisman seisman deleted the gmt-6.2.0rc1/pygmt-helpers-testing branch April 27, 2021 15:27
@weiji14 weiji14 mentioned this pull request Apr 27, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants