Skip to content

Update fig.contour baseline images for GMT 6.2.0rc1 #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 22, 2021

Description of proposed changes

Address #1217

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.4.0 milestone Apr 22, 2021
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 22, 2021
@seisman seisman mentioned this pull request Apr 22, 2021
3 tasks
@github-actions
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_contour_from_file.png
modified pygmt/tests/baseline/test_contour_matrix.png
modified pygmt/tests/baseline/test_contour_vec.png

Image diff(s)

Added images

Modified images

Path Old New
test_contour_from_file.png
test_contour_matrix.png
test_contour_vec.png

Report last updated at commit 9a76222

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an interim failure on the Windows Python 3.9 / NumPy 1.20 test at https://github.com/GenericMappingTools/pygmt/pull/1234/checks?check_run_id=2414981771#step:7:21, but I think it should be fine as all the other tests pass.

@seisman seisman merged commit 0050eec into master Apr 22, 2021
@seisman seisman deleted the gmt-6.2.0rc1/contour branch April 22, 2021 23:41
michaelgrund pushed a commit to michaelgrund/pygmt that referenced this pull request Apr 23, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants