-
Notifications
You must be signed in to change notification settings - Fork 228
Update makecpt baseline images for GMT 6.2.0rc1 #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit ca3906e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, hold on, the makecpt
tests are still failing https://github.com/GenericMappingTools/pygmt/pull/1231/checks?check_run_id=2414367157#step:11:687:
___________________________ test_makecpt_categorical ___________________________
Error: Image dimensions did not match.
Expected shape: (122, 1432)
/Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_makecpt.test_makecpt_categorical/baseline.png
Actual shape: (120, 1432)
/Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_makecpt.test_makecpt_categorical/result.png
_____________________________ test_makecpt_cyclic ______________________________
Error: Image dimensions did not match.
Expected shape: (122, 1529)
/Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_makecpt.test_makecpt_cyclic/baseline.png
Actual shape: (120, 1528)
/Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_makecpt.test_makecpt_cyclic/result.png
Locally it passes for me with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a URL to the PyGMT issue to keep track.
Co-authored-by: Wei Ji <[email protected]>
…1231) * Mark makecpt tests with xfail Co-authored-by: Wei Ji <[email protected]>
Description of proposed changes
Address #1217
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version