Skip to content

Update makecpt baseline images for GMT 6.2.0rc1 #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 27, 2021
Merged

Conversation

maxrjones
Copy link
Member

Description of proposed changes

Address #1217

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones mentioned this pull request Apr 22, 2021
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_makecpt_categorical.png
modified pygmt/tests/baseline/test_makecpt_cyclic.png

Image diff(s)

Added images

Modified images

Path Old New
test_makecpt_categorical.png
test_makecpt_cyclic.png

Report last updated at commit ca3906e

@seisman seisman added this to the 0.4.0 milestone Apr 22, 2021
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 22, 2021
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, hold on, the makecpt tests are still failing https://github.com/GenericMappingTools/pygmt/pull/1231/checks?check_run_id=2414367157#step:11:687:

___________________________ test_makecpt_categorical ___________________________
Error: Image dimensions did not match.
  Expected shape: (122, 1432)
    /Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_makecpt.test_makecpt_categorical/baseline.png
  Actual shape: (120, 1432)
    /Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_makecpt.test_makecpt_categorical/result.png
_____________________________ test_makecpt_cyclic ______________________________
Error: Image dimensions did not match.
  Expected shape: (122, 1529)
    /Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_makecpt.test_makecpt_cyclic/baseline.png
  Actual shape: (120, 1528)
    /Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_makecpt.test_makecpt_cyclic/result.png

@maxrjones
Copy link
Member Author

Locally it passes for me with pytest pygmt/tests/test_makecpt.py but fails with make test. I will need to look into this more but do not have time right now. I will tomorrow but if anyone else wants to take this over to finish quicker that is fine.

@maxrjones maxrjones requested a review from weiji14 April 27, 2021 03:14
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a URL to the PyGMT issue to keep track.

@weiji14 weiji14 merged commit e840f5d into master Apr 27, 2021
@weiji14 weiji14 deleted the gmt-6.2.0rc1/makecpt branch April 27, 2021 04:11
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants