Skip to content

Migrate Figure.plot3d tests to dvc #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 3, 2021
Merged

Migrate Figure.plot3d tests to dvc #1164

merged 8 commits into from
Apr 3, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Related to #1131.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund marked this pull request as draft April 2, 2021 17:34
@michaelgrund michaelgrund added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 2, 2021
@michaelgrund michaelgrund added this to the 0.4.0 milestone Apr 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_plot3d_colors.png
added pygmt/tests/baseline/test_plot3d_colors_sizes.png
added pygmt/tests/baseline/test_plot3d_colors_sizes_proj.png
added pygmt/tests/baseline/test_plot3d_from_file.png
added pygmt/tests/baseline/test_plot3d_matrix.png
added pygmt/tests/baseline/test_plot3d_matrix_color.png
added pygmt/tests/baseline/test_plot3d_projection.png
added pygmt/tests/baseline/test_plot3d_red_circles_zscale.png
added pygmt/tests/baseline/test_plot3d_red_circles_zsize.png
added pygmt/tests/baseline/test_plot3d_scalar_xyz.png
added pygmt/tests/baseline/test_plot3d_sizes.png
added pygmt/tests/baseline/test_plot3d_sizes_colors_transparencies.png
added pygmt/tests/baseline/test_plot3d_transparency.png
added pygmt/tests/baseline/test_plot3d_varying_transparency.png
added pygmt/tests/baseline/test_plot3d_vectors.png

Image diff(s)

  • pygmt/tests/baseline/test_plot3d_colors.png

  • pygmt/tests/baseline/test_plot3d_colors_sizes.png

  • pygmt/tests/baseline/test_plot3d_colors_sizes_proj.png

  • pygmt/tests/baseline/test_plot3d_from_file.png

  • pygmt/tests/baseline/test_plot3d_matrix.png

  • pygmt/tests/baseline/test_plot3d_matrix_color.png

  • pygmt/tests/baseline/test_plot3d_projection.png

  • pygmt/tests/baseline/test_plot3d_red_circles_zscale.png

  • pygmt/tests/baseline/test_plot3d_red_circles_zsize.png

  • pygmt/tests/baseline/test_plot3d_scalar_xyz.png

  • pygmt/tests/baseline/test_plot3d_sizes.png

  • pygmt/tests/baseline/test_plot3d_sizes_colors_transparencies.png

  • pygmt/tests/baseline/test_plot3d_transparency.png

  • pygmt/tests/baseline/test_plot3d_varying_transparency.png

  • pygmt/tests/baseline/test_plot3d_vectors.png

Report last updated at commit e0f4a23

@michaelgrund michaelgrund marked this pull request as ready for review April 3, 2021 07:47
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor typo, otherwise looks fine :)

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Apr 3, 2021
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 3, 2021
@seisman seisman merged commit bdd58e1 into master Apr 3, 2021
@seisman seisman deleted the test-plot3d-dvc branch April 3, 2021 15:09
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants