Skip to content

Migrate Figure.coast tests to dvc #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 118 commits into from
Closed

Migrate Figure.coast tests to dvc #1102

wants to merge 118 commits into from

Conversation

willschlitzer
Copy link
Contributor

Changing the tests in test_coast.py to use mpl_image_compare and adding the reference images to dvc.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer
Add cyl_transverse_mercator.py
27f5d20
@willschlitzer
Add cyl_universal_transverse_mercator.py
d64983f
@willschlitzer
Changing land color to red in cyl_mercator.py to match GMT docs examp…
6ba8185 
…le; changing units from US to SI
@willschlitzer
Merge branch 'master' into cylindrical-projections
76850ee
@willschlitzer
Merge branch 'master' of https://github.com/GenericMappingTools/pygmt
48431db 
# Conflicts:
#	examples/projections/cyl/cyl_transverse_mercator.py
#	examples/projections/cyl/cyl_universal_transverse_mercator.py
@willschlitzer
Merge branch 'master' of https://github.com/GenericMappingTools/pygmt
01052d2
@willschlitzer
Merge remote-tracking branch 'origin/master'
c710988
@willschlitzer
Merge branch 'master' of https://github.com/GenericMappingTools/pygmt
b94e0a2
@willschlitzer
Merge branch 'master' of https://github.com/GenericMappingTools/pygmt
413fec1
@willschlitzer
Merge branch 'master' of https://github.com/GenericMappingTools/pygmt
be51e2c
@willschlitzer
Initial add of solar function to base_plotting.py
bc05e5b
@willschlitzer
Add fill and day_night parameter doc string
219ba77
@willschlitzer
Add additional parameters
83417d7
@willschlitzer
Add terminator doc strings
a68f21d
@willschlitzer
Add timestamp to doc string
43b75c8
@willschlitzer
Add test_solar to test_solar.py
7b65d42
@willschlitzer
Add test_solar_coast to test_solar.py
58add00
@willschlitzer
Add test_solar_pen to test_solar.py
a5e808b
@willschlitzer
Add test_solar_civil_twighlight and test_solar_nautical_twighlight to…
9cd30db 
… test_solar.py
@willschlitzer
Add test_solar_astronomical_twighlight to test_solar.py
9c1221e
@willschlitzer
Add test_solar_fill_transparency to test_solar.py
de414f7
@willschlitzer
Add 5 tests to test_solar.py
8887811
@willschlitzer
Update solar doc string in base_plotting.py
cc02480
@willschlitzer
Add solar to api/index.rst
62c43d7
@willschlitzer
Removing time zone mention until fixed in upstream GMT
01d0a9b
@willschlitzer
Remove solar_coast
74b7bcb
@willschlitzer
Remove solar_fill and solar_fill_transparency
c7935a1
@willschlitzer
Remove solar_pen
1ea53b8
@willschlitzer
Remove solar_xy_shift
25544a9
@willschlitzer
Remove solar_perspective
6391dea
willschlitzer and others added 24 commits March 19, 2021 13:52
@willschlitzer @seisman
Update pygmt/src/solar.py
02c77fa 
Co-authored-by: Dongdong Tian <[email protected]>
@willschlitzer @seisman
Apply suggestions from code review
14265f4 
Co-authored-by: Dongdong Tian <[email protected]>
@willschlitzer
formatting fix
e60ce74
@willschlitzer
add TODO
f1ace0c
@willschlitzer
update pen width
990bc65
@willschlitzer
update teminator_datetime docstring
2e5e151
@willschlitzer
update default time in docstring
631b24d
@willschlitzer
run make format
d7afb77
@willschlitzer @weiji14 @seisman
Apply suggestions from code review
0a3350d 
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
@willschlitzer
Merge branch 'master' into wrap-solar
2a30f5f
@willschlitzer @seisman
Apply suggestions from code review
05f804d 
Co-authored-by: Dongdong Tian <[email protected]>
@willschlitzer
Merge branch 'master' into wrap-solar
c0502ee
@willschlitzer
run make format
7124ad1
@willschlitzer
update test_coast() to use long-form aliases
fb3a721
@willschlitzer
update test_coast_iceland() to use @mpl_image_compare
3a8deaf
@willschlitzer
update test_coast_aliases() to use @mpl_image_compare
29e4e80
@willschlitzer
update test_coast_dcw_single() to use @mpl_image_compare
6ca11db
@willschlitzer
update test_coast_dcw_multiple() to use @mpl_image_compare
59e0e17
@willschlitzer
update test_coast_dcw_list() to use @mpl_image_compare
5aff498
@willschlitzer
update test_coast_dcw_continent() to use @mpl_image_compare
0823d1d
@willschlitzer
update test_coast_dcw_states() to use @mpl_image_compare
a58fdd6
@willschlitzer
Add dvc files for test_coast.py
385fd4e
@willschlitzer
Update main docstring in test_coast.py
4168b19
@willschlitzer
Remove deleted reference images
a1aef1b
@maxrjones
Copy link
Member

maxrjones commented Mar 22, 2021 •
edited
Loading

Did this branch maybe get made off a fork that's behind the pygmt master branch? I think that could be why there's so many commits involved, which isn't great.

Edit - didn't actually look at the commits. Maybe it's a branch off the solar branch? Can you fix this?

@willschlitzer
Copy link
Contributor Author

willschlitzer commented Mar 22, 2021 •
edited
Loading

Did this branch maybe get made off a fork that's behind the pygmt master branch? I think that could be why there's so many commits involved, which isn't great.

Yep. Forgot to switch back to set the remote as PyGMT repo after I switched to my fork to checkout wrap-solar. I'll close this PR. and try again.

@willschlitzer willschlitzer deleted the coast-test-dvc branch March 22, 2021 21:55
@willschlitzer willschlitzer mentioned this pull request Mar 22, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willschlitzer @maxrjones @actions-bot @seisman