-
Notifications
You must be signed in to change notification settings - Fork 228
Support policy for optional dependencies (contextily, geopandas, rioxarray, etc) #3456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds good to me. For point 2, I think we still should set minimum pins if we know that old versions definitely won't work. For example, pin |
Ok, sounds good to me. For geopandas, the last non 1.x release is 0.14.4 (28 Apr 2024), so we could decide to pin to >=1.x on 28 Apr 2025. The other optional dependencies aren't too problematic yet I think, so we can just leave them unpinned until they cause issues. |
Bumps minimum supported GeoPandas version to 1.0 in the pyproject.toml and environment.yml files. Xref #3456
Bumps minimum supported GeoPandas version to 1.0 in the pyproject.toml and environment.yml files. Xref #3456 * Test geopandas=1.0 in ci_tests_legacy.yaml * Remove workaround for geopandas<1 in pygmt/helpers/tempfile.py Workaround added in #3247 for geopandas v0.x and v1.x compatibility. * Remove geopandas <1 and >=1 pin in ci_tests.yaml
Uh oh!
There was an error while loading. Please reload this page.
Opening a thread to discuss whether a formal policy should be put in place for testing optional dependencies listed under the
pyproject.toml
file at:pygmt/pyproject.toml
Lines 41 to 48 in 9a12ae9
Originally posted by @weiji14 in #3420 (comment)
@seisman suggested at #3420 (comment) the following:
So I guess we can do the following:
pyproject.toml
, but allow for breaking backwards compatibility (e.g. drop geopandas v0.x support) after 1 year.Thoughts?
The text was updated successfully, but these errors were encountered: