DVC: Migrate from tracking directories to tracking files for doc images #8010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, please ignore the "DVC diff" workflow failure, which is likely an upstream dvc issue. |
seisman
commented
Nov 3, 2023
| outs: | ||
| - md5: 08a2e5d2a7f9135d82ea0ae2ac99579f | ||
| size: 338598 | ||
| hash: md5 |
There was a problem hiding this comment.
@PaulWessel all the new .dvc files added by me have the hash: md5 line, which is something new in newer dvc versions. Maybe it's easier if you can upgrade your dvc version.
PaulWessel
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Sorry @seisman, been busy with many things today, not all GMT..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DVC provides two different ways to track files: (1) tracking individual files (one
.dvcfile for each .PS file); (2) tracking a directory (one.dvcfile for the whole directory).Currently, we're using the 2nd way, which causes many troubles for us (see #5724 (comment) for context).
In this PR, I've changed the way we tracked PS files in the
docsdirectory to the first way. The biggest benefit is that we can have multiple PRs that work on updating documentation images without worrying about any conflicts.In the future, if someone wants to update ex01.ps, then he needs to:
doc/examples/images/ex01.psdvc add doc/examples/images/ex01.psrather thandvc add doc/examples/images/Please note that the way we track the PS files for tests are not changed.