Skip to content

Migrate remaining test images to DVC #6301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Feb 7, 2022
Merged

Migrate remaining test images to DVC #6301

merged 34 commits into from
Feb 7, 2022

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Feb 4, 2022

Description of proposed changes

This PR migrates all remaining .PS files used for tests from Git to DVC. The tests workflow still fails due to some OS-specific failures, which can be investigated separately.

Part of #5724

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones changed the title WIP: Migrate remaining test images to DVC Migrate remaining test images to DVC Feb 7, 2022
@maxrjones maxrjones requested a review from a team February 7, 2022 20:42
Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@maxrjones maxrjones merged commit 980fb63 into master Feb 7, 2022
@maxrjones maxrjones deleted the migrate-tests branch February 7, 2022 22:48
@maxrjones maxrjones added the maintenance Boring but important stuff for the core devs label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants