Skip to content

Only set undefined axes when drawn #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Only set undefined axes when drawn #4957

merged 1 commit into from
Mar 13, 2021

Conversation

maxrjones
Copy link
Member

Description of proposed changes

Fixes these two examples:

gmt basemap -R0/1/0/1 -JX5c -B+t"ABC" -png map
gmt begin colorbar png
gmt makecpt -Cbatlow -T0/10/1
gmt basemap -R20/30/-10/10 -B
gmt colorbar
gmt end show

Fixes #4955 (partly)

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones requested review from seisman and PaulWessel March 13, 2021 21:00
@maxrjones
Copy link
Member Author

maxrjones commented Mar 13, 2021

A few tests fail. ex16.sh, ex39.sh, and ex43.sh seem to relate to changes in the map frame pen. categoricalcpt.sh now has labels on the colorbar; the reference file for this was not updated by the themes merge.

@PaulWessel
Copy link
Member

Let me know what issues you may want me to look at, i.e., the problems reported by Dongdong.

@PaulWessel PaulWessel merged commit 9d6a505 into master Mar 13, 2021
@PaulWessel PaulWessel deleted the themes-cpt-fix branch March 13, 2021 21:27
@maxrjones
Copy link
Member Author

Let me know what issues you may want me to look at, i.e., the problems reported by Dongdong.

I haven't started looking at any of the other issues yet. Would you want to look into the automatic frame intervals changes?

We can update any PostScript files after all the various issues get resolved, since the plots may change each time.

@PaulWessel
Copy link
Member

OK, just started trying to deal with

coast -Rd -JKf12c -Bafg -Ggreen -png map

first.

maxrjones pushed a commit that referenced this pull request Mar 14, 2021
maxrjones pushed a commit that referenced this pull request Mar 14, 2021
* Update PS for failing tests after #4954

* Update PS for failing tests after #4957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential issues or breaking changes with the GMT modern theme?
2 participants