Skip to content

grdhisteq -D<table> writes to standard output #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxrjones opened this issue Sep 19, 2021 · 1 comment · Fixed by #5822
Closed

grdhisteq -D<table> writes to standard output #5785

maxrjones opened this issue Sep 19, 2021 · 1 comment · Fixed by #5822
Labels
bug Something isn't working

Comments

@maxrjones
Copy link
Member

Description of the problem

Even when <table> is provided after -D for grdhisteq, the output still gets sent to standard output. Should the docs or code be updated? This is the current description in the usage message:

  -D[<table>]
     Dump level information to <table> or standard output if not given.

Full script that generated the error

gmt grdhisteq @earth_relief_01d -R-5/5/-5/5 -Dtest.txt

Actual outcome

Result written to standard output.

Expected outcome

Result written to test.txt

System information

  • Operating system: macOS
  • GMT version (gmt --version): 6.3
@maxrjones maxrjones added the bug Something isn't working label Sep 19, 2021
@PaulWessel
Copy link
Member

Hm, can confirm what you say. Not sure why the table file is not used - will need to debug. It is an old module that Walter wrote that probably should be refactored so that output can happen in the main and not hidden inside a function that does the computation (this all predates the API).

PaulWessel added a commit that referenced this issue Sep 29, 2021
See #5785 for background.  Now the lower functions returns the cell boundaries and we properly create a dataset that is written to the file or stdout.  Closes #5785.
PaulWessel added a commit that referenced this issue Sep 29, 2021
See #5785 for background.  Now the lower functions returns the cell boundaries and we properly create a dataset that is written to the file or stdout.  Closes #5785.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants