-
Notifications
You must be signed in to change notification settings - Fork 0
feat: visualize well intersection in geos-trame #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: visualize well intersection in geos-trame #83
Conversation
63b5196
to
78b5427
Compare
78b5427
to
240f54e
Compare
Improve DeckViewer to be able to show mesh (Region), wells (InternalWell, Vtkmesh) and perforation (Perforation) Update also the gui to be able to hide and control radius property of these datas.
240f54e
to
9d78f30
Compare
@lucas-givord geos-trame install works but when running geos-trame it seems the directory "geos-trame/src/geos_trame/module/serve" is missing. This directory was present in the previous delivery of geos-trame.
|
@mlemayTTE |
@lucas-givord ok following the README.md, the |
d0f8999
to
7f2b31c
Compare
@mlemayTTE could you please review and test it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me ! @alexbenedicto could you merge this PR when you have some time?
By now Trame is independant from the other packages, but we will work on mutualizing functions in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use git-lfs for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't push this .vtu file, it seems that this repository reached is limit with lfs:
batch response: This repository exceeded its LFS budget. The account responsible for the budget should increase it to restore access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified my test and the associated deck to not have to push this vtu (I reuse the .vtu from another test). Let me know if I need to modify something else
2f8aae7
to
09de5a0
Compare
09de5a0
to
db0659c
Compare
Previously we didn't take in account the connectivty. The geosDeck used in the test has been updated to check this fix.
Adding an alert system to notify user about error. It is used in the viewer.py to notify the user about missing dataset mandaotry to read a well or a perforation
To avoid LFS storage limit, test_well_intersection will reuse the mesh from the other deck xml.
db0659c
to
4b4c384
Compare
This PR add intersection capability in geos-trame when a user want to display a well and a perforation (part of #85)
The DeckViewer has been improved to control well and perforation radius with slider widgets.
Preview of the 3DView with few perforation and well
close #86