Skip to content

Commit 182b2a8

Browse files
authored
Reduce visibility of nested structures after refactoring. (#1720)
1 parent eecd70c commit 182b2a8

File tree

6 files changed

+34
-33
lines changed

6 files changed

+34
-33
lines changed

src/coreComponents/constitutive/fluid/CompressibleSinglePhaseFluid.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class CompressibleSinglePhaseFluid : public SingleFluidBase
133133
*/
134134
KernelWrapper createKernelWrapper();
135135

136-
struct viewKeyStruct : public SingleFluidBase::viewKeyStruct
136+
struct viewKeyStruct
137137
{
138138
static constexpr char const * compressibilityString() { return "compressibility"; }
139139
static constexpr char const * viscosibilityString() { return "viscosibility"; }

src/coreComponents/constitutive/fluid/ParticleFluid.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class ParticleFluid : public ParticleFluidBase
209209

210210
// *** Data repository keys
211211

212-
struct viewKeyStruct : public ParticleFluidBase::viewKeyStruct
212+
struct viewKeyStruct
213213
{
214214
static constexpr char const * fluidViscosityString() { return "fluidViscosity"; }
215215
static constexpr char const * proppantDiameterString() { return "proppantDiameter"; }

src/coreComponents/constitutive/fluid/ParticleFluidBase.hpp

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,6 @@ class ParticleFluidBase : public ConstitutiveBase
154154

155155
static constexpr localIndex MAX_NUM_COMPONENTS = 4;
156156

157-
// *** Data repository keys
158-
159-
struct viewKeyStruct
160-
{
161-
static constexpr char const * maxProppantConcentrationString() { return "maxProppantConcentration"; }
162-
static constexpr char const * isCollisionalSlipString() { return "isCollisionalSlip"; }
163-
};
164-
165157
protected:
166158

167159
virtual void postProcessInput() override;
@@ -180,6 +172,15 @@ class ParticleFluidBase : public ConstitutiveBase
180172

181173
real64 m_maxProppantConcentration;
182174

175+
private:
176+
177+
// *** Data repository keys
178+
struct viewKeyStruct
179+
{
180+
static constexpr char const * maxProppantConcentrationString() { return "maxProppantConcentration"; }
181+
static constexpr char const * isCollisionalSlipString() { return "isCollisionalSlip"; }
182+
};
183+
183184
};
184185

185186
} //namespace constitutive

src/coreComponents/constitutive/fluid/ProppantSlurryFluid.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ class ProppantSlurryFluid : public SlurryFluidBase
307307

308308
// *** Data repository keys
309309

310-
struct viewKeyStruct : public SlurryFluidBase::viewKeyStruct
310+
struct viewKeyStruct
311311
{
312312
static constexpr char const * compressibilityString() { return "compressibility"; }
313313
static constexpr char const * referencePressureString() { return "referencePressure"; }

src/coreComponents/constitutive/fluid/SingleFluidBase.hpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -185,14 +185,6 @@ class SingleFluidBase : public ConstitutiveBase
185185
real64 defaultDensity() const { return m_defaultDensity; }
186186
real64 defaultViscosity() const { return m_defaultViscosity; }
187187

188-
// *** Data repository keys
189-
190-
struct viewKeyStruct
191-
{
192-
static constexpr char const * defaultDensityString() { return "defaultDensity"; }
193-
static constexpr char const * defaultViscosityString() { return "defaultViscosity"; }
194-
};
195-
196188
protected:
197189

198190
virtual void postProcessInput() override;
@@ -208,6 +200,14 @@ class SingleFluidBase : public ConstitutiveBase
208200
array2d< real64 > m_viscosity;
209201
array2d< real64 > m_dViscosity_dPressure;
210202

203+
private:
204+
205+
// *** Data repository keys
206+
struct viewKeyStruct
207+
{
208+
static constexpr char const * defaultDensityString() { return "defaultDensity"; }
209+
static constexpr char const * defaultViscosityString() { return "defaultViscosity"; }
210+
};
211211
};
212212

213213
} //namespace constitutive

src/coreComponents/constitutive/fluid/SlurryFluidBase.hpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -310,20 +310,6 @@ class SlurryFluidBase : public ConstitutiveBase
310310

311311
bool isNewtonianFluid() const { return m_isNewtonianFluid; }
312312

313-
// *** Data repository keys
314-
315-
struct viewKeyStruct
316-
{
317-
static constexpr char const * componentNamesString() { return "componentNames"; }
318-
319-
static constexpr char const * defaultDensityString() { return "defaultDensity"; }
320-
static constexpr char const * defaultCompressibilityString() { return "defaultCompressibility"; }
321-
static constexpr char const * defaultViscosityString() { return "defaultViscosity"; }
322-
323-
static constexpr char const * flowBehaviorIndexString() { return "flowBehaviorIndex"; }
324-
static constexpr char const * flowConsistencyIndexString() { return "flowConsistencyIndex"; }
325-
};
326-
327313
protected:
328314

329315
virtual void postProcessInput() override;
@@ -361,6 +347,20 @@ class SlurryFluidBase : public ConstitutiveBase
361347

362348
bool m_isNewtonianFluid;
363349

350+
private:
351+
352+
// *** Data repository keys
353+
struct viewKeyStruct
354+
{
355+
static constexpr char const * componentNamesString() { return "componentNames"; }
356+
357+
static constexpr char const * defaultDensityString() { return "defaultDensity"; }
358+
static constexpr char const * defaultCompressibilityString() { return "defaultCompressibility"; }
359+
static constexpr char const * defaultViscosityString() { return "defaultViscosity"; }
360+
361+
static constexpr char const * flowBehaviorIndexString() { return "flowBehaviorIndex"; }
362+
static constexpr char const * flowConsistencyIndexString() { return "flowConsistencyIndex"; }
363+
};
364364
};
365365

366366
} //namespace constitutive

0 commit comments

Comments
 (0)