Always try and close the socket on SocketException.

Author: robotdan

src/main/java/io/fusionauth/http/server/internal/HTTPWorker.java

@@ -256,11 +256,12 @@ public void run() {
       logger.debug("[{}] Closing socket with status [{}]. Bad request, failed to parse request. Reason [{}] Parser state [{}]", Thread.currentThread().threadId(), Status.BadRequest, e.getMessage(), e.getState());
       closeSocketOnError(response, Status.BadRequest);
     } catch (SocketException e) {
-      // This should only happen when the server is shutdown and this thread is waiting to read or write. In that case, this will throw a
-      // SocketException and the thread will be interrupted. Since the server is being shutdown, we should let the client know.
+      // When the HTTPServerThread shuts down, we will interrupt each client thread, so debug log it accordingly.
+      // - This will cause the socket to throw a SocketException, so log it.
       if (Thread.currentThread().isInterrupted()) {
-        // Close socket only. We do not want to potentially delay the shutdown at all.
         logger.debug("[{}] Closing socket. Server is shutting down.", Thread.currentThread().threadId());
+      } else {
+        logger.debug("[{}] Closing socket. The socket by a client, proxy or otherwise.", Thread.currentThread().threadId());
       }
       closeSocketOnly(CloseSocketReason.Expected);
     } catch (IOException e) {