MQTTv5 Implementation #316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bot run formatting |
|
/bot run formatting |
1 similar comment
|
/bot run formatting |
| # This file includes the relevant testing commands required for | ||
| # testing this directory and lists subdirectories to be tested as well. | ||
| subdirs("unit-test/MQTT") | ||
| subdirs("unit-test/MQTTv5") |
There was a problem hiding this comment.
We should get rid of this separate subdir command here as we have just 1 directory for the unit tests now.
| @@ -21,6 +20,9 @@ library has also undergone both static code analysis from | |||
| safety through the | |||
| [CBMC automated reasoning tool](https://www.cprover.org/cbmc/). | |||
|
|
|||
| -For MQTT v3.1.1(https://docs.oasis-open.org/mqtt/mqtt/v3.1.1/mqtt-v3.1.1.html), use code from tag : | |||
| -For MQTT v5.0(https://docs.oasis-open.org/mqtt/mqtt/v5.0/mqtt-v5.0.html), use code from tag : | |||
There was a problem hiding this comment.
We can have hyperlinks here instead of direct pasted links. We can also add the links for the tags:
for 2.3.1: https://github.com/FreeRTOS/coreMQTT/tree/v2.3.1
for 3.0.0: https://github.com/FreeRTOS/coreMQTT/tree/v3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading MQTT Library to support v5 features
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.