Coverity Report Directory Fix #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… current directory. The step either needed to have the working-directory: set to the build directory, or the tar file needs to be created in the parent directory.
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 6 6
Lines 3179 3179
Branches 885 885
=======================================
Hits 2977 2977
Misses 95 95
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aggarg
approved these changes
Nov 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
sirnish
approved these changes
Nov 27, 2023
kar-rahul-aws
approved these changes
Nov 28, 2023
tony-josi-aws
added a commit
that referenced
this pull request
Nov 28, 2023
* Revert "The curl command to send the report expects the tar file to be in its current directory. The step either needed to have the working-directory: set to the build directory, or the tar file needs to be created in the parent directory. (#903)" This reverts commit 76f3aa5. * Update to separate build and upload steps --------- Co-authored-by: tony-josi-aws <[email protected]>
laroche
pushed a commit
to laroche/FreeRTOS-Kernel
that referenced
this pull request
Apr 18, 2024
Update the unit test for the following functions to verify that equal priority task won't be preempted * vTaskResume * xTaskResumeFromISR * vTaskPrioritySet * xTaskResumeAll 4 test cases are added to verify this scenario * test_xTaskResumeAll_success_2_tasks_eq_prio_running_no_yield * test_vTaskPrioritySet_success_eq_curr_prio_curr_tcb * test_vTaskResume_success_eq_curr_prio_not_yield * test_xTaskResumeFromISR_success_eq_curr_prio_suspended_task Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The curl command to send the report expects the tar file to be in its current directory. The step either needed to have the working-directory: set to the build directory, or the tar file needs to be created in the parent directory.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.