Support for optionally allocating stacks separate from the heap. #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new configuration macro (configSUPPORT_SEPARATE_STACK_ALLOCATION) was added to allow stack allocation calls in tasks.c to be redirected to a new portable layer allocation function. This allows a client to opt to add a separate stack allocator for dynamic stack allocation. The default is the current behavior, which is to allocate stacks with pvPortMalloc.
aggarg
reviewed
Feb 12, 2021
| @@ -896,6 +896,11 @@ | |||
| #define configSUPPORT_DYNAMIC_ALLOCATION 1 | |||
| #endif | |||
|
|
|||
| #ifndef configSUPPORT_SEPARATE_STACK_ALLOCATION | |||
There was a problem hiding this comment.
Please change the config parameter name to configSTACK_ALLOCATION_FROM_SEPARATE_HEAP.
|
Please add |
|
I have addressed the suggested name change and spell check failure in this PR: #267 I needed to open a separate PR because I did not have write access to https://github.com/DoverMicrosystems/FreeRTOS-Kernel. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional Separate Stack Allocation
Description
This change adds support for a new configuration parameter (configSUPPORT_SEPARATE_STACK_ALLOCATION), defaulted to 0, which when set will cause dynamic stack allocation to use new portable layer functions pvPortMallocStack and vPortFreeStack instead of pvPortMalloc and vPortFree. This allows a client the option of providing separate allocators for stacks and the heap.
The changes are limited to the kernel, proper. Sample allocators are not provided.
Test Steps
Compile tasks.c with the new configuration parameter set to 0 and 1, and observe the changes of calls to pvPortMalloc/vPortFree to pvPortMallocStack/vPortFreeStack.
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.