Skip to content

Posix: fix copyright #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Posix: fix copyright #250

merged 2 commits into from
Apr 21, 2021

Conversation

unspecd
Copy link
Contributor

@unspecd unspecd commented Jan 20, 2021

This fixes compilation error when configENABLE_BACKWARD_COMPATIBILITY is 0.

@unspecd unspecd requested a review from a team as a code owner January 20, 2021 03:11
@unspecd
Copy link
Contributor Author

unspecd commented Jan 20, 2021

Should I squash everything into 1 commit?

@dachalco
Copy link
Contributor

dachalco commented Jan 26, 2021

@unspecd

Thanks for bringing this up. Reviewing now.

@dachalco dachalco requested a review from aggarg January 26, 2021 20:33
@dachalco
Copy link
Contributor

dachalco commented Jan 26, 2021

@unspecd

Is there a particular reason for removing these macros?
The preprocessor can do the same replacement with:

#define pdTASK_CODE TaskFunction_t

Some questionable changes/effects:

  • This removes the convenient ability to redefine the task function signature in Thread_t via pdTASK_CODE
  • port.c copyright should remain unchanged
    • You can omit files from the check by listing and committing them in your repo's
      .github/scripts/kernel_checker.py

@dachalco dachalco removed the request for review from aggarg January 26, 2021 22:48
@unspecd unspecd force-pushed the fix/posix-compat branch 2 times, most recently from 4e282d7 to 9086d42 Compare January 27, 2021 19:28
@unspecd
Copy link
Contributor Author

unspecd commented Jan 27, 2021

This removes the convenient ability to redefine the task function signature in Thread_t via pdTASK_CODE

Oh, I didn't take this into account.

@unspecd
Copy link
Contributor Author

unspecd commented Jan 27, 2021

port.c copyright should remain unchanged

OK, changed to "Cambridge Consultants Ltd".

@unspecd unspecd force-pushed the fix/posix-compat branch from 64db3e0 to 96c227a Compare March 8, 2021 00:30
@unspecd unspecd changed the title Posix: remove compatibility macros Posix: fix copyright Mar 8, 2021
@unspecd unspecd requested a review from dachalco March 8, 2021 00:32
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #250 (88a5316) into main (6bf3a75) will increase coverage by 4.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   90.60%   95.36%   +4.76%     
==========================================
  Files           3        4       +1     
  Lines         532     1187     +655     
  Branches      142      334     +192     
==========================================
+ Hits          482     1132     +650     
- Misses         14       17       +3     
- Partials       36       38       +2     
Flag Coverage Δ
unittests 95.36% <ø> (+4.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
queue.c 99.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf3a75...88a5316. Read the comment docs.

@dan4thewin dan4thewin merged commit ac2c383 into FreeRTOS:main Apr 21, 2021
@unspecd unspecd deleted the fix/posix-compat branch April 23, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants