Updates to Uncrustify Formatting #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skptak
force-pushed
the
uncrustifyFormatting
branch
from
8275240 to
374c07d
Compare
This was referenced Aug 31, 2023
|
Does this not duplicate work from #82? |
Skptak
force-pushed
the
uncrustifyFormatting
branch
from
374c07d to
294ee0a
Compare
…ses. Add a README in, and add in the gitattribute file so the line endings don't get changed
Skptak
force-pushed
the
uncrustifyFormatting
branch
from
294ee0a to
44112c3
Compare
|
This is for uncrustify formatting |
Skptak
force-pushed
the
uncrustifyFormatting
branch
from
254b2e6 to
21f2da8
Compare
2 tasks
rawalexe
previously approved these changes
Sep 1, 2023
…Also use quiet versions of the actions for use in large repos. This keeps the git log smaller so the page doesn't glitch out trying to show you the results
Skptak
force-pushed
the
uncrustifyFormatting
branch
from
21f2da8 to
9fd21d0
Compare
rawalexe
approved these changes
Sep 1, 2023
paulbartell
reviewed
Sep 1, 2023
| push: | ||
| branches: ["**"] | ||
| pull_request: | ||
| branches: [main,v2] |
There was a problem hiding this comment.
will this branch always exist?
paulbartell
reviewed
Sep 1, 2023
| @@ -0,0 +1,100 @@ | |||
| #include <stdint.h> | |||
There was a problem hiding this comment.
Is this supposed to be named README.md?
paulbartell
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
It's not super clear from first glance what each of the test files is verifying. It would be preferable to specify what rules / portion of the style standard are being validated by each test file.
This is better than the current state of this check, so approving it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up #68 into more manageable single PRs containing just the changes to the individual actions
Will not be doing the YML files one by one, so please reference the #68 actions for proof of working
Relevant test logs can be found here