-
Notifications
You must be signed in to change notification settings - Fork 493
Conversation
Only remaining issue was: @proppy @ed7coyne |
Yes, the usbserial is the same as the regular TX/RX pins. It doesn't seems ESP has more than 1 hardware UART routed to the module (see https://github.com/esp8266/Arduino/blob/633e48f3aec5f1c3c11d4498fc90d378d49e6e9f/cores/esp8266/uart.c#L27) so if we choose other pin, we would be effectively stealing 2 other digital I/O. Maybe we could interleave the DEBUG message with the main UART port (with a |
I don't think stealing 2 other I/O pins are an issue here. The host here is only acting as a gateway to the cloud so it does not need any of it's local i/o pins for anything other than serial. Interleaving with the main serial link would work but I don't see a lot of value in it. To me the primary usecase here will be debugging interactions with another device, so you connect this modem example on an esp to an Arduino and run it. In that case you want to see the debug output on the PC while it communicates with the Arduino. |
I think it would be nice if people could try the modem from the Arduino IDE without connecting an additional board for the first time. It's a good way to play around with firebase from the Serial Monitor, maybe we could make that a #define they could overwrite when they go to prod? |
Alright lets try to make it configurable. |
@ed7coyne also feel free to commit as it, if travis is happy about it and just file a bug to make it configurable. |
Sounds good, I will open a Issue for it. Also unless you fixed it in your latest PR Travis is only actually testing the "Push" example. We should extend it to all of the examples. |
Yes, since you're adding a new sample this PR should probably add it to the CI :) |
Added to travis. |
Merging PR based on previous approval. |
Added in #66 but moved here when that was abandoned.