Improve stability of the repo

[kotl]

This update contains:

• using shared_ptr properly instead of unique_ptr
• use latest JSON library and deleting old one (please download it from head or use stable release)
  https://github.com/bblanchon/ArduinoJson
• do not crash when streaming deletions as well as allowing to detect deletion

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[proppy]

Can you add the new version of ArduinoJson to the third-party directory?

[kotl]

Finally fixed both CI builds.

[proppy]

are you removing nightly on purpose?

[proppy]

I'm curious why this is not already added by the board package:
https://github.com/esp8266/Arduino/blob/master/boards.txt#L1353

[kotl]

It did not work without it, I had to create my own travis docker container to figure out why the heck it was failing.

[proppy]

Maybe we should add a new # DEPENDENCIES sections in the README?

[kotl]

Done.

[proppy]

Maybe this could simply be statically allocated as
StaticJsonBuffer<FIREBASE_JSONBUFFER_SIZE> buffer_ without shared_ptr?

[kotl]

I don't remember the details, but I am pretty sure latest version of JSONArduino is very strict on memory allocations so passing this buffer around as-is results in compilation errors.

[proppy]

ping?

[hunsalz]

Any update appreciated. - It would be great to dissolve the current dependency to the contributed JSON library and use Arduino JSON form head or a stable version.

[kotl]

I am really sorry, I did not follow up on these changes. This change was intended to be complemented by other changes in the main esp8266 repo for handling https contexts to make a rock solid firmware that never crashes and also allowing firebase-arduino for 2 simultaneous connections to stream and write at the same time. And the moment I had it working well, esp8266 repo got changed so much, that fixes I already tested and debugged for many days, stopped working, so regrettably I decided to abandon this route.

However, I believe there is still a benefit to get this change in for firebase-arduino repo, so if @proppy let's me try again, I would be happy to submit this.

[kotl]

@proppy , @vikrum can you take a look again at this?

[hunsalz]

@kotl can you try again with a signed CLA?

[googlebot]

CLAs look good, thanks!

[kotl]

Done!

[proppy]

Thanks for working on this!

[proppy]

Tested successfully with the following sketch

void setup() {
  Serial.begin(9600);
  
  // connect to wifi.
  WiFi.begin(WIFI_SSID, WIFI_PASSWORD);
  Serial.print("connecting");
  while (WiFi.status() != WL_CONNECTED) {
    Serial.print(".");
    delay(500);
  }
  Serial.println();
  Serial.print("connected: ");
  Serial.println(WiFi.localIP());
  
  Firebase.begin(FIREBASE_HOST, FIREBASE_SECRET);
}


void loop() {
  Firebase.stream("/");

  if (Firebase.failed()) {
    Serial.println("streaming error");
    Serial.println(Firebase.error());
    return;
  }
  
  if (Firebase.available()) {
     FirebaseObject event = Firebase.readEvent();
     String eventType = event.getString("type");
     eventType.toLowerCase();
     Serial.print("event: ");
     Serial.println(eventType);
     if (eventType == "put") {
       String path = event.getString("path");
       int data = event.getInt("data");
       Serial.print("data: ");
       Serial.print(path);
       Serial.print("=");
       Serial.println(data);
     }
  }
 }

[lenguyenvu007]

Thank you for your update, Stream works fine. But if I test changing value by Update, not Set.
After then eventType = "patch", Stream does not return any data. Any suggestion about this case ?

[proppy]

@lenguyenvu007 can you file a separate issue about this? Thanks!