This repository was archived by the owner on Mar 17, 2025. It is now read-only.
FirebaseHttpClient: add forceReuse #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proppy
commented
Apr 10, 2017
src/FirebaseHttpClient_Esp8266.cpp
Outdated
| class FirebaseHttpClientEsp8266 : public FirebaseHttpClient { | ||
| public: | ||
| FirebaseHttpClientEsp8266() {} | ||
|
|
||
| void setReuseConnection(bool reuse) override { | ||
| void setReuseConnection(bool reuse) override { |
ed7coyne
approved these changes
Apr 17, 2017
proppy
commented
Apr 17, 2017
src/FirebaseHttpClient_Esp8266.cpp
Outdated
| class ForceReuseHTTPClient : public HTTPClient { | ||
| public: | ||
| void end() { | ||
| if(connected()) { |
There was a problem hiding this comment.
another possibility is to call HTTPClient::end here with _canReuse set to true before it?
There was a problem hiding this comment.
I like that better only because it deviates less from the base so as the base changes we can merge with impunity.
|
It worked for me |
|
Merging: sorry all for the delay. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230 #286