Report error when streaming loses connection. #179
Conversation
| @@ -18,8 +18,7 @@ FIREBASE_DIR=.. | |||
| GTEST_DIR=googletest/googletest | |||
| ARDUINOJSON_DIR=../src/third-party/arduino-json-5.3 | |||
|
|
|||
| FIREBASE_SRCS=${FIREBASE_DIR}/src/FirebaseObject.cpp\ | |||
| ${FIREBASE_DIR}/src/FirebaseObject.h | |||
| FIREBASE_SRCS=${FIREBASE_DIR}/src/FirebaseObject.cpp | |||
There was a problem hiding this comment.
If you have the .h here when you run "make clean" it deletes it. We also don't need it.
There was a problem hiding this comment.
ouch, maybe we should just have a _DEPS
There was a problem hiding this comment.
I think we are fine just leaving it out, it works this way.
There was a problem hiding this comment.
yep, the only gotcha is that it won't force to recompile if the .h changes.
|
Hi @ed7coyne, When device is losing wifi (wifi turned off) I got an exception. Is this because your branch not yet merged? |
|
@ed7coyne can you rebase and see if the build still fails? |
|
@SpencerCornish I wonder if this will be fixed by #330 ? /cc @kotl |
|
@kotl is this included in your recent changes? |
|
It now is included in this pull request: |
|
Closing since this is now merged. |
Fixes #177.