You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 17, 2025. It is now read-only.
I find that the current API (esp, thanks to @ed7coyne refactoring & testability) strike a good compromise between user facing usability and modularity for downstream like the modem.
We chose this compromise because ongoing tension between using modern C++ idiom to make it friendly to build downstream program (like the modem) or following https://www.arduino.cc/en/Reference/APIStyleGuide and make it friendly to the lambda Arduino user, the discussion on #93 is a good illustration of this.
I'd like us to iterate on the current design to create 2 API surfaces:
an Arduino-friendly 'layer' with the following properties:
only 1 top level type, exposed as a global Firebase object.
only basic type (int, float, String, bool) as arguments and return values, no stl type or pointers
stateful (only one operation at a time)
optional error handling (exposed thru boolean method: connected(), success(), failed() on the main object).
compose well with existing Arduino abstraction: Client
exposed as one dependency.
a C++ friendly 'layer' with the following properties:
follow modern C++ best practice
strict and verbose error handling
leverage heavily memory management of the STL and built in containers
mockable and testable
decouple transport types from the firebase protocol implementation and its payloads.
I think that with #90 we're very close to 2. but I'd like to work on building 1. on top of it: as part of #80#81#82.
Let's discuss it :)
The text was updated successfully, but these errors were encountered:
proppy
changed the title
2 api surface proposal
2 api surfaces proposal
Apr 23, 2016
This sounds good to me. I think that #1 should be using #2 in its implementation, so it will just be a thin layer on top, that way most of the logic would be testable. I think you are proposing that but wanted to be sure.
proppy
added a commit
to proppy/firebase-arduino
that referenced
this issue
Apr 27, 2016
I find that the current API (esp, thanks to @ed7coyne refactoring & testability) strike a good compromise between user facing usability and modularity for downstream like the modem.
We chose this compromise because ongoing tension between using modern C++ idiom to make it friendly to build downstream program (like the modem) or following https://www.arduino.cc/en/Reference/APIStyleGuide and make it friendly to the lambda Arduino user, the discussion on #93 is a good illustration of this.
I'd like us to iterate on the current design to create 2 API surfaces:
Firebase
object.connected()
,success()
,failed()
on the main object).Client
I think that with #90 we're very close to
2.
but I'd like to work on building1.
on top of it: as part of #80 #81 #82.Let's discuss it :)
The text was updated successfully, but these errors were encountered: