Skip to content
This repository was archived by the owner on Feb 21, 2024. It is now read-only.

Lowercase all identifiers #2240

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sql3/parser/ast.go
Original file line number Diff line number Diff line change
Expand Up @@ -1593,6 +1593,10 @@ func IdentName(ident *Ident) string {
return ident.Name
}

func CaseNeutralIdentName(ident *Ident) string {
return strings.ToLower(IdentName(ident))
}

type Variable struct {
NamePos Pos // variable position
Name string // variable name
Expand Down
6 changes: 3 additions & 3 deletions sql3/planner/compilecreatetable.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ type createTableField struct {
// compileCreateTableStatement compiles a CREATE TABLE statement into a
// PlanOperator.
func (p *ExecutionPlanner) compileCreateTableStatement(stmt *parser.CreateTableStatement) (_ types.PlanOperator, err error) {
tableName := parser.IdentName(stmt.Name)
tableName := parser.CaseNeutralIdentName(stmt.Name)
failIfExists := !stmt.IfNotExists.IsValid()

// apply table options
Expand All @@ -50,7 +50,7 @@ func (p *ExecutionPlanner) compileCreateTableStatement(stmt *parser.CreateTableS

var columns = []*createTableField{}
for _, col := range stmt.Columns {
columnName := parser.IdentName(col.Name)
columnName := parser.CaseNeutralIdentName(col.Name)
typeName := parser.IdentName(col.Type.Name)

if strings.ToLower(columnName) == "_id" {
Expand All @@ -77,7 +77,7 @@ func (p *ExecutionPlanner) compileCreateTableStatement(stmt *parser.CreateTableS
// compiles a column def
func (p *ExecutionPlanner) compileColumn(col *parser.ColumnDefinition) (*createTableField, error) {
var err error
columnName := parser.IdentName(col.Name)
columnName := parser.CaseNeutralIdentName(col.Name)
typeName := parser.IdentName(col.Type.Name)

column := &createTableField{
Expand Down
2 changes: 1 addition & 1 deletion sql3/planner/compiledroptable.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
// compileDropTableStatement compiles a DROP TABLE statement into a
// PlanOperator.
func (p *ExecutionPlanner) compileDropTableStatement(stmt *parser.DropTableStatement) (_ types.PlanOperator, err error) {
tableName := parser.IdentName(stmt.Name)
tableName := parser.CaseNeutralIdentName(stmt.Name)
tname := dax.TableName(tableName)
tbl, err := p.schemaAPI.TableByName(context.Background(), tname)
if err != nil {
Expand Down