Skip to content

JsonNodeFactory method numberNode(long) produces IntNode for small numbers #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cowtowncoder opened this issue May 20, 2015 · 0 comments
Closed

JsonNodeFactory method numberNode(long) produces IntNode for small numbers #797

cowtowncoder opened this issue May 20, 2015 · 0 comments
Milestone
2.6.0

Comments

@cowtowncoder
Copy link
Member

Looks like method numberNode(long) (and wrapped variant, numberNode(Long)) will try to optimize things by constructing an IntNode if value fits in int. I don't think this makes sense; and it will also make it impossible to resolve #504.

So, for 2.6, I will change the behavior. While this is backwards-incompatible change, in practice it should not lead to problems (never say never but...), but causes problems currently.
@cowtowncoder cowtowncoder added this to the 2.6.0 milestone May 20, 2015
cowtowncoder added a commit that referenced this issue May 20, 2015
@cowtowncoder
Fix #504 and #797
23e52ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
1 participant
@cowtowncoder