Fix #1906

Author: cowtowncoder

release-notes/CREDITS-2.x

@@ -740,5 +740,7 @@ Alexander Skvortcov (askvortcov@github)
    (2.9.4)
 
 Joe Schafer (jschaf@github)
+  * Reported #1906: Add string format specifier for error message in `PropertyValueBuffer`
+   (2.9.4)
   * Reported #1907: Remove `getClass()` from `_valueType` argument for error reporting
    (2.9.4)

release-notes/VERSION-2.x

@@ -1,7 +1,9 @@
-Project: jackson-databin------------------------------------------------------------------------
-=== Releases === 
+------------------------------------------------------------------------
+Project: jackson-databind
 ------------------------------------------------------------------------
 
+=== Releases === 
+
 2.9.4 (not yet released)
 
 #1673: Serialising generic value classes via Reference Types (like Optional) fails
@@ -27,6 +29,8 @@ Project: jackson-databin--------------------------------------------------------
  (reported by mcortella@github)
 #1899: Another two gadgets to exploit default typing issue in jackson-databind
  (reported by OneSourceCat@github)
+#1906: Add string format specifier for error message in `PropertyValueBuffer`
+ (reported by Joe S)
 #1907: Remove `getClass()` from `_valueType` argument for error reporting
  (reported by Joe S)
 

src/main/java/com/fasterxml/jackson/databind/deser/impl/PropertyValueBuffer.java

@@ -131,9 +131,9 @@ public Object getParameter(SettableBeanProperty prop)
             value = _creatorParameters[prop.getCreatorIndex()] = _findMissing(prop);
         }
         if (value == null && _context.isEnabled(DeserializationFeature.FAIL_ON_NULL_CREATOR_PROPERTIES)) {
-            return _context.reportInputMismatch(prop, String.format(
-                "Null value for creator property '%s'; DeserializationFeature.FAIL_ON_NULL_FOR_CREATOR_PARAMETERS enabled",
-                prop.getName(), prop.getCreatorIndex()));
+            return _context.reportInputMismatch(prop,
+                "Null value for creator property '%s' (index %d); `DeserializationFeature.FAIL_ON_NULL_FOR_CREATOR_PARAMETERS` enabled",
+                prop.getName(), prop.getCreatorIndex());
         }
         return value;
     }
@@ -172,7 +172,7 @@ public Object[] getParameters(SettableBeanProperty[] props)
                 if (_creatorParameters[ix] == null) {
                     SettableBeanProperty prop = props[ix];
                     _context.reportInputMismatch(prop.getType(),
-                            "Null value for creator property '%s' (index %d); DeserializationFeature.FAIL_ON_NULL_FOR_CREATOR_PARAMETERS enabled",
+                            "Null value for creator property '%s' (index %d); `DeserializationFeature.FAIL_ON_NULL_FOR_CREATOR_PARAMETERS` enabled",
                             prop.getName(), props[ix].getCreatorIndex());
                 }
             }
@@ -191,14 +191,13 @@ protected Object _findMissing(SettableBeanProperty prop) throws JsonMappingExcep
         }
         // Second: required?
         if (prop.isRequired()) {
-            _context.reportInputMismatch(prop, String.format(
-                    "Missing required creator property '%s' (index %d)",
-                    prop.getName(), prop.getCreatorIndex()));
+            _context.reportInputMismatch(prop, "Missing required creator property '%s' (index %d)",
+                    prop.getName(), prop.getCreatorIndex());
         }
         if (_context.isEnabled(DeserializationFeature.FAIL_ON_MISSING_CREATOR_PROPERTIES)) {
-            _context.reportInputMismatch(prop, String.format(
-                    "Missing creator property '%s' (index %d); DeserializationFeature.FAIL_ON_MISSING_CREATOR_PROPERTIES enabled",
-                    prop.getName(), prop.getCreatorIndex()));
+            _context.reportInputMismatch(prop,
+                    "Missing creator property '%s' (index %d); `DeserializationFeature.FAIL_ON_MISSING_CREATOR_PROPERTIES` enabled",
+                    prop.getName(), prop.getCreatorIndex());
         }
         // Third: default value
         JsonDeserializer<Object> deser = prop.getValueDeserializer();