Skip to content

Commit 6e6968f

Browse files
author
Dave Barach
committed
vppinfra: fix typo in dlmalloc.c
Fix libffi package name for Ubuntu 20.04 Type: fix Signed-off-by: Dave Barach <[email protected]> Change-Id: Idc567717494b4c40c307f20a40d5e10cd26b0a46
1 parent 0d90ed9 commit 6e6968f

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Makefile

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,19 +66,23 @@ DEB_DEPENDS += debhelper dkms git libtool libapr1-dev dh-systemd
6666
DEB_DEPENDS += libconfuse-dev git-review exuberant-ctags cscope pkg-config
6767
DEB_DEPENDS += lcov chrpath autoconf indent clang-format libnuma-dev
6868
DEB_DEPENDS += python-all python3-all python3-setuptools
69-
DEB_DEPENDS += python-virtualenv python-pip libffi6 check
69+
DEB_DEPENDS += python-virtualenv python-pip check
7070
DEB_DEPENDS += libboost-all-dev libffi-dev python3-ply libmbedtls-dev
7171
DEB_DEPENDS += cmake ninja-build uuid-dev python3-jsonschema python3-yaml
7272
DEB_DEPENDS += python3-venv # ensurepip
7373
DEB_DEPENDS += python3-dev # needed for python3 -m pip install psutil
7474
# python3.6 on 16.04 requires python36-dev
7575

76+
LIBFFI=libffi6 # works on all but 20.04
77+
7678
ifeq ($(OS_VERSION_ID),16.04)
7779
DEB_DEPENDS += python-dev
7880
DEB_DEPENDS += libssl-dev
7981
else ifeq ($(OS_VERSION_ID),18.04)
8082
DEB_DEPENDS += python-dev
8183
DEB_DEPENDS += libssl-dev
84+
else ifeq ($(OS_VERSION_ID),20.04)
85+
LIBFFI=libffi7
8286
else ifeq ($(OS_ID)-$(OS_VERSION_ID),debian-8)
8387
DEB_DEPENDS += libssl-dev
8488
APT_ARGS = -t jessie-backports
@@ -88,6 +92,8 @@ else
8892
DEB_DEPENDS += libssl-dev
8993
endif
9094

95+
DEB_DEPENDS += $(LIBFFI)
96+
9197
RPM_DEPENDS = redhat-lsb glibc-static
9298
RPM_DEPENDS += apr-devel
9399
RPM_DEPENDS += numactl-devel

src/vppinfra/dlmalloc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1249,7 +1249,7 @@ static struct malloc_state _gm_;
12491249
#define disable_expand(M) ((M)->mflags |= USE_NOEXPAND_BIT)
12501250
#define use_trace(M) ((M)->mflags & USE_TRACE_BIT)
12511251
#define enable_trace(M) ((M)->mflags |= USE_TRACE_BIT)
1252-
#define disable_trace(M) ((M)->mflags |= USE_TRACE_BIT)
1252+
#define disable_trace(M) ((M)->mflags &= ~USE_TRACE_BIT)
12531253

12541254
#define set_lock(M,L)\
12551255
((M)->mflags = (L)?\

0 commit comments

Comments
 (0)