[executions] KotlinDataLoader to provide DataLoader #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelAndalon
added
changes: minor
samuelAndalon
changed the title
dariuszkuc
reviewed
Jun 13, 2022
dariuszkuc
reviewed
Jun 13, 2022
dariuszkuc
approved these changes
Jun 13, 2022
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* feat: KotlinDataLoader to provide DataLoader * feat: adjust coverage * feat: schema generator with dataloader as test dependency * feat: avoid excluding dataloader lib in schema generator * feat: remove unused version variable Co-authored-by: samvazquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
originally we decided to have the
KotlinDataLoaderto allow passing theBatchLoaderfn instead of theDataLoaderinstance because of the new Instrumentation to dispatch aDataLoaderRegistryin a more efficient way, so for that we had to decorate theDataLoaderCacheMapbefore instantiating theDataLoader.a PR in graphql-java-dataloader was merged to natively support what we where doing to the
CacheMap, so we can go back to allow passing aDataLoaderso we can theorically go back to previous KotlinDataLoader implementation.
🔗 Related Issues
#1457