Skip to content

Merge custom directives with federated schema #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

padenj
Copy link

@padenj padenj commented Jan 29, 2020

No description provided.

@padenj
Copy link
Author

padenj commented Jan 29, 2020

Workaround for issue #40

@padenj padenj requested a review from tlivings January 29, 2020 22:16
@kzamer
Copy link

kzamer commented Feb 3, 2020

There's a need on our team to have the @authorize directive added to queries and mutations.
Really interested in this! 👍

@tlivings
Copy link
Collaborator

tlivings commented Feb 3, 2020

Can you add a test for this?

return mergeSchemas({
schemas: [federatedSchema],
schemaDirectives,
mergeDirectives: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to get this working in the unit tests, I had to add mergeDirectives: true here.

Copy link
Collaborator

@tlivings tlivings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tlivings tlivings merged commit fd83daa into ExpediaGroup:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants