Skip to content

Commit c95afc0

Browse files
Revert "Obsolete what was deprecated in v1.2"
This reverts commit c449e11.
1 parent 655c9c9 commit c95afc0

File tree

9 files changed

+43
-29
lines changed

9 files changed

+43
-29
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Obsoleted
2-
// package com.esri.hadoop.hive.serde;
3-
// @Deprecated in v1.2
4-
// public class JsonSerde extends EsriJsonSerDe {}
1+
package com.esri.hadoop.hive.serde;
2+
3+
@Deprecated
4+
public class JsonSerde extends EsriJsonSerDe {}

hive/src/test/java/com/esri/hadoop/hive/serde/TestEsriJsonSerDe.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -421,8 +421,8 @@ public void TestColumnTypes() throws Exception {
421421
fieldData = getField("text", row, rowOI);
422422
Assert.assertEquals("other", ((Text)fieldData).toString());
423423
}
424-
/* *
425-
@Deprecated -> Obsolete
424+
425+
@Deprecated
426426
@Test
427427
public void LegacyName() throws Exception {
428428
ArrayList<Object> stuff = new ArrayList<Object>();
@@ -451,7 +451,7 @@ public void LegacyName() throws Exception {
451451
fieldData = getField("shape", row, rowOI);
452452
ckPoint(new Point(7.0, 2.0), (BytesWritable)fieldData);
453453
}
454-
* */
454+
455455

456456
private SerDe mkSerDe(Properties proptab) throws Exception {
457457
Configuration config = new Configuration();
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1-
// package com.esri.json.hadoop;
2-
// Obsolete - @Deprecated in v1.2 - superseded by EnclosedEsriJsonInputFormat
3-
// public class EnclosedJsonInputFormat extends EnclosedEsriJsonInputFormat {}
1+
package com.esri.json.hadoop;
2+
3+
/**
4+
* @deprecated superseded by EnclosedEsriJsonInputFormat
5+
*/
6+
@Deprecated
7+
public class EnclosedJsonInputFormat extends EnclosedEsriJsonInputFormat {}

json/src/main/java/com/esri/json/hadoop/EnclosedJsonRecordReader.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1-
/* *
21
package com.esri.json.hadoop;
2+
33
import java.io.IOException;
44
import org.apache.hadoop.conf.Configuration;
5-
* Obsolete - renamed to and superseded by EnclosedEsriJsonRecordReader
6-
@Deprecated in v1.2
5+
6+
/**
7+
* @deprecated renamed to and superseded by EnclosedEsriJsonRecordReader
8+
*/
9+
@Deprecated
710
public class EnclosedJsonRecordReader extends EnclosedEsriJsonRecordReader {
811
public EnclosedJsonRecordReader() throws IOException { // explicit just to declare exception
912
super();
@@ -13,4 +16,3 @@ public EnclosedJsonRecordReader(org.apache.hadoop.mapred.InputSplit split,
1316
super(split, conf);
1417
}
1518
}
16-
* */
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1-
// package com.esri.json.hadoop;
2-
// Obsolete - @Deprecated in v1.2 - superseded by UnenclosedEsriJsonInputFormat
3-
// public class UnenclosedJsonInputFormat extends UnenclosedEsriJsonInputFormat {}
1+
package com.esri.json.hadoop;
2+
3+
/**
4+
* @deprecated superseded by UnenclosedEsriJsonInputFormat
5+
*/
6+
@Deprecated
7+
public class UnenclosedJsonInputFormat extends UnenclosedEsriJsonInputFormat {}

json/src/main/java/com/esri/json/hadoop/UnenclosedJsonRecordReader.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1-
/* *
21
package com.esri.json.hadoop;
2+
33
import java.io.IOException;
44
import org.apache.hadoop.conf.Configuration;
5-
* Obsolete renamed to and superseded by UnenclosedEsriJsonRecordReader
6-
@Deprecated in v1.2
5+
6+
/**
7+
* @deprecated renamed to and superseded by UnenclosedEsriJsonRecordReader
8+
*/
9+
@Deprecated
710
public class UnenclosedJsonRecordReader extends UnenclosedEsriJsonRecordReader {
811
public UnenclosedJsonRecordReader() throws IOException { // explicit just to declare exception
912
super();
@@ -13,4 +16,3 @@ public UnenclosedJsonRecordReader(org.apache.hadoop.mapred.InputSplit split,
1316
super(split, conf);
1417
}
1518
}
16-
* */

json/src/test/java/com/esri/json/hadoop/TestEnclosedEsriJsonRecordReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public void TestMrv1() throws Exception {
8989
assertFalse (reader.next(key, value));
9090
reader.close();
9191
}
92-
/* * Obsolete
92+
9393
@Test
9494
public void TestLegacy() throws Exception {
9595
Path path = new Path(this.getClass().getResource("sample-study-area.json").getFile());
@@ -104,5 +104,5 @@ public void TestLegacy() throws Exception {
104104
assertFalse (reader.next(key, value));
105105
reader.close();
106106
}
107-
* */
107+
108108
}

json/src/test/java/com/esri/json/hadoop/TestUnenclosedEsriJsonRecordMrv1.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,10 @@ public void TestGeomFirst() throws IOException {
227227
}
228228

229229

230-
/* *
230+
/**
231231
* @deprecated superseded by UnenclosedEsriJsonRecordReader
232-
@Deprecated in v1.2 -> Obsolete
232+
*/
233+
@Deprecated
233234
@Test
234235
public void TestLegacyName() throws Exception {
235236
Assert.assertArrayEquals(new int[] { 0, 1 }, getRecordIndexesInReader(getLegacyReader("unenclosed-json-simple.json", 0, 63)));
@@ -250,5 +251,5 @@ private UnenclosedEsriJsonRecordReader getLegacyReader(String resource, int star
250251

251252
return new UnenclosedJsonRecordReader(split, conf);
252253
}
253-
* */
254+
254255
}

json/src/test/java/com/esri/json/hadoop/TestUnenclosedEsriJsonRecordReader.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -277,9 +277,10 @@ public void TestGeomFirst() throws Exception {
277277
}
278278

279279

280-
/* *
280+
/**
281281
* @deprecated superseded by UnenclosedEsriJsonRecordReader
282-
@Deprecated in v1.2 -> Obsolete
282+
*/
283+
@Deprecated
283284
@Test
284285
public void TestLegacyName() throws Exception {
285286
UnenclosedEsriJsonRecordReader uejrr = new UnenclosedJsonRecordReader();
@@ -293,5 +294,5 @@ public void TestLegacyName() throws Exception {
293294
Assert.assertArrayEquals(new int[] { 0 }, getRecordIndexesInFile(uejrr, "unenclosed-json-simple.json", 0, 23));
294295
Assert.assertArrayEquals(new int[] { 1 }, getRecordIndexesInFile(uejrr, "unenclosed-json-simple.json", 23, 41));
295296
}
296-
* */
297+
297298
}

0 commit comments

Comments
 (0)