Skip to content

Commit 8a5ef1d

Browse files
committed
feat: use traced_call when unrolling iterators and generators (#1642)
* feat: better support for Base.Generators * feat: use traced_call when unrolling iterators and generators * fix: closure with call working * fix: try removing nospecialize * fix: use a looped version of any to avoid inference issues * fix: dont overlay inside compiler call
1 parent 5fcf427 commit 8a5ef1d

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

src/Reactant.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,6 @@ use_overlayed_version(::TracedRArray) = true
193193
use_overlayed_version(::TracedRNumber) = true
194194
use_overlayed_version(::Number) = false
195195
use_overlayed_version(::MissingTracedValue) = true
196-
use_overlayed_version(::Vector{<:AnyTracedRArray}) = true
197196
use_overlayed_version(::AbstractArray{<:TracedRNumber}) = true
198197
use_overlayed_version(rng::ReactantRNG) = use_overlayed_version(rng.seed)
199198
function use_overlayed_version(x::AbstractArray)

src/TracedRArray.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1532,7 +1532,6 @@ end
15321532

15331533
unwrapped_broadcast(f::F, xs) where {F} = unrolled_map(f, xs)
15341534

1535-
# TODO: once traced_call supports internal mutations, we can use traced_call here
15361535
# TODO: we should overload this for Slices and use mapslices instead
15371536
function unrolled_map(f::F, itr) where {F}
15381537
y = Reactant.call_with_reactant(iterate, itr)

0 commit comments

Comments
 (0)