Skip to content

Conversation

SafariMonkey
Copy link
Contributor

Description

If there is no data to return, the "series" key is omitted from the InfluxDB response. As such, defaulting to Vec::new makes sense.

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • Updated README.md using cargo readme -r influxdb -t ../README.tpl > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@Empty2k12 Empty2k12 added the Status: Merge when CI passes This PR has been reviewed and accepted for merge label Aug 22, 2020
Copy link
Collaborator

@Empty2k12 Empty2k12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Excellent catch!

@Empty2k12 Empty2k12 merged commit 9c2f37c into influxdb-rs:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Merge when CI passes This PR has been reviewed and accepted for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants